Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1927113002: Revert of fix build by using ifdef instead of if for SK_DEBUG (Closed)

Created:
4 years, 7 months ago by reed1
Modified:
4 years, 7 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of fix build by using ifdef instead of if for SK_DEBUG (patchset #1 id:1 of https://codereview.chromium.org/1924943003/ ) Reason for revert: need to revert main change for now Original issue's description: > fix build by using ifdef instead of if for SK_DEBUG > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 > > TBR= > NOTRY=True > > Committed: https://skia.googlesource.com/skia/+/b8498825b54718cdd90c30c39323cfc433695f23 TBR=djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/9fbee8408ec4578aead049f1bf43f1d9d4039b7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkResourceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of fix build by using ifdef instead of if for SK_DEBUG
4 years, 7 months ago (2016-04-28 15:11:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927113002/1
4 years, 7 months ago (2016-04-28 15:11:47 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 15:11:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9fbee8408ec4578aead049f1bf43f1d9d4039b7b

Powered by Google App Engine
This is Rietveld 408576698