Speed up Binops

src/hydrogen-instructions.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 443 matching lines @@
     result = HType::Boolean();
   } else if (value->IsJSObject()) {
     result = HType::JSObject();
   } else if (value->IsJSArray()) {
     result = HType::JSArray();
   }
   return result;
 }
 
 
+Handle< ::v8::internal::Type> HType::intersect(
+    Handle< ::v8::internal::Type> type, Isolate* isolate) {
+  if (IsSmi())     return handle(::v8::internal::Type::Smi(), isolate);

[Jakob Kummerow, 2013/07/18 11:56:15]

This is not a generic implementation of intersection. At the very least, you
should ASSERT(type->Is(Type::Smi())). 

+  if (IsString())  return handle(::v8::internal::Type::String(), isolate);
+  if (IsBoolean()) return handle(::v8::internal::Type::Boolean(), isolate);
+  if (IsHeapNumber() || IsTaggedNumber()) {
+    return handle(::v8::internal::Type::Intersect(
+          type, handle(::v8::internal::Type::Number(), isolate)), isolate);
+  }
+  if (IsNonPrimitive() || IsJSObject()) {
+    return handle(::v8::internal::Type::Intersect(
+          type, handle(::v8::internal::Type::NonSmi(), isolate)), isolate);
+  }
+  return type;
+}
+
+
 bool HValue::Dominates(HValue* dominator, HValue* dominated) {
   if (dominator->block() != dominated->block()) {
     // If they are in different blocks we can use the dominance relation
     // between the blocks.
     return dominator->block()->Dominates(dominated->block());
   } else {
     // Otherwise we must see which instruction comes first, considering
     // that phis always precede regular instructions.
     if (dominator->IsInstruction()) {
       if (dominated->IsInstruction()) {
@@ skipping 3520 matching lines @@
     case kBackingStore:
       if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString());
       stream->Add("[backing-store]");
       break;
   }
 
   stream->Add("@%d", offset());
 }
 
 } }  // namespace v8::internal