Fix projection touch HUD in RTL

ash/touch/touch_hud_projection.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/touch/touch_hud_projection.h"
 
 #include "ash/root_window_controller.h"
 #include "ash/shell.h"
 #include "ash/wm/property_util.h"
 #include "third_party/skia/include/effects/SkGradientShader.h"
@@ skipping 17 matching lines @@
 // TouchPointView draws a single touch point. This object manages its own
 // lifetime and deletes itself upon fade-out completion or whenever |Remove()|
 // is explicitly called.
 class TouchPointView : public views::View,
                        public ui::AnimationDelegate,
                        public views::WidgetObserver {
  public:
   explicit TouchPointView(views::Widget* parent_widget)
       : circle_center_(kPointRadius + 1, kPointRadius + 1),
         gradient_center_(SkPoint::Make(kPointRadius + 1,
-                                       kPointRadius + 1)) {
+                                       kPointRadius + 1)),
+        parent_(parent_widget->GetContentsView()) {
     SetPaintToLayer(true);
     SetFillsBoundsOpaquely(false);
 
     SetSize(gfx::Size(2 * kPointRadius + 2, 2 * kPointRadius + 2));
 
     stroke_paint_.setStyle(SkPaint::kStroke_Style);
     stroke_paint_.setColor(kProjectionStrokeColor);
 
     gradient_colors_[0] = kProjectionFillColor;
     gradient_colors_[1] = kProjectionStrokeColor;
 
     gradient_pos_[0] = SkFloatToScalar(0.9f);
     gradient_pos_[1] = SkFloatToScalar(1.0f);
 
-    parent_widget->GetContentsView()->AddChildView(this);
+    parent_->AddChildView(this);
 
     parent_widget->AddObserver(this);
   }
 
   void UpdateTouch(const ui::TouchEvent& touch) {
     if (touch.type() == ui::ET_TOUCH_RELEASED ||
         touch.type() == ui::ET_TOUCH_CANCELLED) {
       fadeout_.reset(new ui::LinearAnimation(kFadeoutDurationInMs,
                                              kFadeoutFrameRate,
                                              this));
       fadeout_->Start();
     } else {
-      SetX(touch.root_location().x() - kPointRadius - 1);

[sadrul, 2013/07/15 21:44:06]

Can you use:
  SetX(parent()->GetMirroredXInView(touch.root_location().x()) - kPointRadius -
1);
instead?

[mohsen, 2013/07/15 22:10:52]

Yes, much better. Done.

-      SetY(touch.root_location().y() - kPointRadius - 1);
+      gfx::Point position(touch.root_location().x() - kPointRadius - 1,
+                          touch.root_location().y() - kPointRadius - 1);
+      if (base::i18n::IsRTL())
+        position.set_x(parent_->width() - position.x() - width());
+      SetPosition(position);
     }
   }
 
   void Remove() {
     delete this;
   }
 
  private:
   virtual ~TouchPointView() {
     GetWidget()->RemoveObserver(this);
@@ skipping 39 matching lines @@
   }
 
   // Overridden from views::WidgetObserver.
   virtual void OnWidgetDestroying(views::Widget* widget) OVERRIDE {
     fadeout_->Stop();
   }
 
   const gfx::Point circle_center_;
   const SkPoint gradient_center_;
 
+  View* parent_;
+
   SkPaint fill_paint_;
   SkPaint stroke_paint_;
   SkColor gradient_colors_[2];
   SkScalar gradient_pos_[2];
 
   scoped_ptr<ui::Animation> fadeout_;
 
   DISALLOW_COPY_AND_ASSIGN(TouchPointView);
 };
 
@@ skipping 40 matching lines @@
   controller->set_touch_hud_projection(this);
 }
 
 void TouchHudProjection::UnsetHudForRootWindowController(
     RootWindowController* controller) {
   controller->set_touch_hud_projection(NULL);
 }
 
 }  // namespace internal
 }  // namespace ash