Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1927073002: Correctly set the closing condition in array patterns. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly set the closing condition in array patterns. This fixes a bug where the iterable's .return method gets called when it shouldn't. R=littledan@chromium.org BUG=v8:4952 LOG=n Committed: https://crrev.com/622c92b88f5a7fe478494fb46f741a1d29830810 Cr-Commit-Position: refs/heads/master@{#35850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -16 lines) Patch
M src/parsing/pattern-rewriter.cc View 4 chunks +31 lines, -16 lines 0 comments Download
M test/mjsunit/harmony/iterator-close.js View 3 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 7 months ago (2016-04-28 08:09:11 UTC) #1
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-04-28 08:40:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927073002/1
4 years, 7 months ago (2016-04-28 09:28:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 09:59:58 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/622c92b88f5a7fe478494fb46f741a1d29830810
Cr-Commit-Position: refs/heads/master@{#35850}

Powered by Google App Engine
This is Rietveld 408576698