Mac: Introduce "StaticCast" variants of base::mac::FooCastStrict, which do not typecheck in Release

base/mac/foundation_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_MAC_FOUNDATION_UTIL_H_
 #define BASE_MAC_FOUNDATION_UTIL_H_
 
 #include <CoreFoundation/CoreFoundation.h>
 
 #include <string>
@@ skipping 254 matching lines @@
 // CFNumberRef some_number = base::mac::CFCast<CFNumberRef>(
 //     CFArrayGetValueAtIndex(array, index));
 //
 // CFTypeRef hello = CFSTR("hello world");
 // CFStringRef some_string = base::mac::CFCastStrict<CFStringRef>(hello);
 
 template<typename T>
 T CFCast(const CFTypeRef& cf_val);
 
 template<typename T>
-T CFCastStrict(const CFTypeRef& cf_val);
+T CFCastStrict(const CFTypeRef& cf_val) {
+  DCHECK(!cf_val || CFCast<T>(cf_val));
+  // Note: CFTypeRef is const void*, but CGColorRef and some others are non-
+  // const. So this may also cast away a const qualifier.
+  return (T)(cf_val);
+}
 
 #define CF_CAST_DECL(TypeCF) \
 template<> BASE_EXPORT TypeCF##Ref \
-CFCast<TypeCF##Ref>(const CFTypeRef& cf_val);\
-\
-template<> BASE_EXPORT TypeCF##Ref \
-CFCastStrict<TypeCF##Ref>(const CFTypeRef& cf_val);
+CFCast<TypeCF##Ref>(const CFTypeRef& cf_val);
 
 CF_CAST_DECL(CFArray);
 CF_CAST_DECL(CFBag);
 CF_CAST_DECL(CFBoolean);
 CF_CAST_DECL(CFData);
 CF_CAST_DECL(CFDate);
 CF_CAST_DECL(CFDictionary);
 CF_CAST_DECL(CFNull);
 CF_CAST_DECL(CFNumber);
 CF_CAST_DECL(CFSet);
@@ skipping 39 matching lines @@
 template<typename T>
 T* ObjCCast(id objc_val) {
   if ([objc_val isKindOfClass:[T class]]) {
     return reinterpret_cast<T*>(objc_val);
   }
   return nil;
 }
 
 template<typename T>
 T* ObjCCastStrict(id objc_val) {
-  T* rv = ObjCCast<T>(objc_val);
-  DCHECK(objc_val == nil || rv);
-  return rv;
+  DCHECK(!objc_val || ObjCCast<T>(objc_val));
+  return reinterpret_cast<T*>(objc_val);
 }
 
 #endif  // defined(__OBJC__)
 
 // Helper function for GetValueFromDictionary to create the error message
 // that appears when a type mismatch is encountered.
 BASE_EXPORT std::string GetValueFromDictionaryErrorMessage(
     CFStringRef key, const std::string& expected_type, CFTypeRef value);
 
 // Utility function to pull out a value from a dictionary, check its type, and
@@ skipping 34 matching lines @@
 // by using the NSToCFCast methods above.
 // e.g. LOG(INFO) << base::mac::NSToCFCast(@"foo");
 // Operator << can not be overloaded for ObjectiveC types as the compiler
 // can not distinguish between overloads for id with overloads for void*.
 BASE_EXPORT extern std::ostream& operator<<(std::ostream& o,
                                             const CFErrorRef err);
 BASE_EXPORT extern std::ostream& operator<<(std::ostream& o,
                                             const CFStringRef str);
 
 #endif  // BASE_MAC_FOUNDATION_UTIL_H_