Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 19270002: This caused failures in ui_unittests FontListTest.Fonts_GetHeight_GetBaseline (Closed)

Created:
7 years, 5 months ago by Mark Mentovai
Modified:
7 years, 5 months ago
Reviewers:
Yuki
CC:
chromium-reviews
Visibility:
Public.

Description

This caused failures in ui_unittests FontListTest.Fonts_GetHeight_GetBaseline http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=30356 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%284%29&number=13543 Revert 211664 "Shows Japanese and English mixed queries correctly." > Shows Japanese and English mixed queries correctly. > > This CL respects the common height and baseline of the fonts in the given font list, and draw text according to the baseline. > > The cause of vertically-misaligned queries was that > 1. ASCII characters have 23 pixels in height > 2. Japanese characters have 17 pixels in height > > pango_layout_get_pixel_size(), which is called in RenderTextLinux::GetStringSize(), returns the above size. > > Also see: > https://docs.google.com/a/chromium.org/document/d/1e2n9lEM_usn37Pld8tMeo_qpfLRQQjkx-O1hTHi3sPo/edit?usp=sharing > > BUG=244323 > TEST=Test manually. > > Review URL: https://chromiumcodereview.appspot.com/18848002 TBR=yukishiino@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -87 lines) Patch
M trunk/src/build/android/pylib/gtest/filter/ui_unittests_disabled View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ui/gfx/font_list.h View 4 chunks +0 lines, -15 lines 0 comments Download
M trunk/src/ui/gfx/font_list.cc View 3 chunks +4 lines, -35 lines 0 comments Download
M trunk/src/ui/gfx/font_list_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M trunk/src/ui/gfx/render_text.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/ui/gfx/render_text_linux.cc View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
7 years, 5 months ago (2013-07-15 19:17:49 UTC) #1
Yuki
7 years, 5 months ago (2013-07-16 06:21:35 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698