DescriptionThis caused failures in ui_unittests FontListTest.Fonts_GetHeight_GetBaseline
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=30356
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%284%29&number=13543
Revert 211664 "Shows Japanese and English mixed queries correctly."
> Shows Japanese and English mixed queries correctly.
>
> This CL respects the common height and baseline of the fonts in the given font list, and draw text according to the baseline.
>
> The cause of vertically-misaligned queries was that
> 1. ASCII characters have 23 pixels in height
> 2. Japanese characters have 17 pixels in height
>
> pango_layout_get_pixel_size(), which is called in RenderTextLinux::GetStringSize(), returns the above size.
>
> Also see:
> https://docs.google.com/a/chromium.org/document/d/1e2n9lEM_usn37Pld8tMeo_qpfLRQQjkx-O1hTHi3sPo/edit?usp=sharing
>
> BUG=244323
> TEST=Test manually.
>
> Review URL: https://chromiumcodereview.appspot.com/18848002
TBR=yukishiino@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211669
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|