Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1926963002:
Flip trybot and waterfall bot for simplechrome amd64 to GN. (Closed)
|
Created:
4 years, 7 months ago by Dirk Pranke Modified:
4 years, 7 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip trybot and waterfall bot for simplechrome amd64 to GN.
This is another attempt at flipping the first simplechrome bots to GN.
R=stevenjb@chromium.org
BUG=433082, 607362
Committed: https://crrev.com/f92633b8307d2a2d1af20e0d5915942b6a03d15d
Cr-Commit-Position: refs/heads/master@{#390298}
Patch Set 1 #Patch Set 2 : comment out bitmaptools for now #Patch Set 3 : updates #
Total comments: 1
Messages
Total messages: 23 (9 generated)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926963002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926963002/40001
Description was changed from ========== Flip trybot and waterfall bot for simplechrome amd64 to GN. This is another attempt at flipping the first simplechrome bots to GN. R=stevenjb@chromium.org BUG=433082 ========== to ========== Flip trybot and waterfall bot for simplechrome amd64 to GN. This is another attempt at flipping the first simplechrome bots to GN. R=stevenjb@chromium.org BUG=433082, 607362 ==========
dpranke@chromium.org changed reviewers: + hashimoto@chromium.org
Please take a look, I think this is good to go and we can start flipping at least one configuration to GN.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1926963002/diff/40001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1926963002/diff/40001/BUILD.gn#newcode109 BUILD.gn:109: #"//third_party/catapult/telemetry:bitmaptools", I know nothing about trybot configs, so just comparing the list of targets in this group and its GYP equivalent in build/all.gyp. Why doesn't this include "//third_party/mesa:osmesa"?
On 2016/04/28 02:26:38, hashimoto wrote: > https://codereview.chromium.org/1926963002/diff/40001/BUILD.gn > File BUILD.gn (right): > > https://codereview.chromium.org/1926963002/diff/40001/BUILD.gn#newcode109 > BUILD.gn:109: #"//third_party/catapult/telemetry:bitmaptools", > I know nothing about trybot configs, so just comparing the list of targets in > this group and its GYP equivalent in build/all.gyp. > > Why doesn't this include "//third_party/mesa:osmesa"? osmesa is built automatically as part of chrome (as is nacl_helper). In GN, for group targets, I usually try to list only the "root" targets that are needed (i.e., targets that are not dependencies of other targets).
On 2016/04/28 02:28:51, Dirk Pranke wrote: > On 2016/04/28 02:26:38, hashimoto wrote: > > https://codereview.chromium.org/1926963002/diff/40001/BUILD.gn > > File BUILD.gn (right): > > > > https://codereview.chromium.org/1926963002/diff/40001/BUILD.gn#newcode109 > > BUILD.gn:109: #"//third_party/catapult/telemetry:bitmaptools", > > I know nothing about trybot configs, so just comparing the list of targets in > > this group and its GYP equivalent in build/all.gyp. > > > > Why doesn't this include "//third_party/mesa:osmesa"? > > osmesa is built automatically as part of chrome (as is nacl_helper). In GN, for > group targets, I usually try to list only the "root" targets that are needed > (i.e., > targets that are not dependencies of other targets). Sorry for being lazy, the same goes for nacl_helper and nacl_helper_bootstrap?
On 2016/04/28 02:35:01, hashimoto wrote: > On 2016/04/28 02:28:51, Dirk Pranke wrote: > > On 2016/04/28 02:26:38, hashimoto wrote: > > > https://codereview.chromium.org/1926963002/diff/40001/BUILD.gn > > > File BUILD.gn (right): > > > > > > https://codereview.chromium.org/1926963002/diff/40001/BUILD.gn#newcode109 > > > BUILD.gn:109: #"//third_party/catapult/telemetry:bitmaptools", > > > I know nothing about trybot configs, so just comparing the list of targets > in > > > this group and its GYP equivalent in build/all.gyp. > > > > > > Why doesn't this include "//third_party/mesa:osmesa"? > > > > osmesa is built automatically as part of chrome (as is nacl_helper). In GN, > for > > group targets, I usually try to list only the "root" targets that are needed > > (i.e., > > targets that are not dependencies of other targets). > > Sorry for being lazy, > the same goes for nacl_helper and nacl_helper_bootstrap? Yes.
BUILD.gn lgtm and rubberstamp for mb_config.pyl
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926963002/40001
Message was sent while issue was closed.
Description was changed from ========== Flip trybot and waterfall bot for simplechrome amd64 to GN. This is another attempt at flipping the first simplechrome bots to GN. R=stevenjb@chromium.org BUG=433082, 607362 ========== to ========== Flip trybot and waterfall bot for simplechrome amd64 to GN. This is another attempt at flipping the first simplechrome bots to GN. R=stevenjb@chromium.org BUG=433082, 607362 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f92633b8307d2a2d1af20e0d5915942b6a03d15d Cr-Commit-Position: refs/heads/master@{#390298}
Message was sent while issue was closed.
Description was changed from ========== Flip trybot and waterfall bot for simplechrome amd64 to GN. This is another attempt at flipping the first simplechrome bots to GN. R=stevenjb@chromium.org BUG=433082, 607362 ========== to ========== Flip trybot and waterfall bot for simplechrome amd64 to GN. This is another attempt at flipping the first simplechrome bots to GN. R=stevenjb@chromium.org BUG=433082, 607362 Committed: https://crrev.com/f92633b8307d2a2d1af20e0d5915942b6a03d15d Cr-Commit-Position: refs/heads/master@{#390298} ========== |
