Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1926933002: Convert generated extension bindings to use base::Value::CreateDeepCopy (Closed)

Created:
4 years, 7 months ago by dcheng
Modified:
4 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert generated extension bindings to use base::Value::CreateDeepCopy BUG=581865 Committed: https://crrev.com/992ba621b0417b47f1ebd1efd99183215085ed2b Cr-Commit-Position: refs/heads/master@{#390239}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Formatted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M tools/json_schema_compiler/cc_generator.py View 1 7 chunks +17 lines, -23 lines 0 comments Download
M tools/json_schema_compiler/util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
4 years, 7 months ago (2016-04-27 22:25:12 UTC) #2
Devlin
lgtm https://codereview.chromium.org/1926933002/diff/1/tools/json_schema_compiler/cc_generator.py File tools/json_schema_compiler/cc_generator.py (right): https://codereview.chromium.org/1926933002/diff/1/tools/json_schema_compiler/cc_generator.py#newcode514 tools/json_schema_compiler/cc_generator.py:514: .Cblock(self._CreateValueFromType('result = %s;', .Append indentation is off now?
4 years, 7 months ago (2016-04-27 22:33:21 UTC) #3
dcheng
https://codereview.chromium.org/1926933002/diff/1/tools/json_schema_compiler/cc_generator.py File tools/json_schema_compiler/cc_generator.py (right): https://codereview.chromium.org/1926933002/diff/1/tools/json_schema_compiler/cc_generator.py#newcode514 tools/json_schema_compiler/cc_generator.py:514: .Cblock(self._CreateValueFromType('result = %s;', On 2016/04/27 at 22:33:21, Devlin wrote: ...
4 years, 7 months ago (2016-04-27 22:43:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926933002/20001
4 years, 7 months ago (2016-04-27 22:43:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 23:47:33 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:14:33 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/992ba621b0417b47f1ebd1efd99183215085ed2b
Cr-Commit-Position: refs/heads/master@{#390239}

Powered by Google App Engine
This is Rietveld 408576698