Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 192693002: gin: Add ability to install call-as-function handlers on gin::Wrappable (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 9 months ago
Reviewers:
dcarney
CC:
chromium-reviews
Visibility:
Public.

Description

gin: Add ability to install call-as-function handlers on gin::Wrappable BUG=347565 R=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255927

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
M gin/function_template.h View 1 chunk +14 lines, -0 lines 0 comments Download
M gin/function_template.h.pump View 1 chunk +14 lines, -0 lines 0 comments Download
M gin/object_template_builder.h View 4 chunks +21 lines, -0 lines 0 comments Download
M gin/wrappable_unittest.cc View 1 3 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-10 12:28:51 UTC) #1
dcarney
lgtm
6 years, 9 months ago (2014-03-10 12:44:51 UTC) #2
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-10 12:55:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r255927 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698