components/resources/autofill_scaled_resources.grdp - Issue 1926903003: PaymentRequest specific card issuer icons

Side by Side Diff: components/resources/autofill_scaled_resources.grdp

Issue 1926903003: PaymentRequest specific card issuer icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <grit-part>	2 <grit-part>

3 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_AMEX" file="autofi ll/amex.png" />	3 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_AMEX" file="autofi ll/amex.png" />

4 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_DISCOVER" file="au tofill/discover.png" />	4 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_DISCOVER" file="au tofill/discover.png" />

5 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_GENERIC" file="aut ofill/cc-generic.png" />	5 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_GENERIC" file="aut ofill/cc-generic.png" />

6 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_MASTERCARD" file=" autofill/mastercard.png" />	6 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_MASTERCARD" file=" autofill/mastercard.png" />

7 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_VISA" file="autofi ll/visa.png" />	7 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_VISA" file="autofi ll/visa.png" />

8	8

9 <if expr="is_android">	9 <if expr="is_android">

10 <!-- These are not used on desktop, only Android, so use a placeholder file.	10 <!-- These are not used on desktop, only Android, so use a placeholder file.

11 TODO(rouslan): Remove non-keyboard-accessory icon when keyboard	11 TODO(rouslan): Remove non-keyboard-accessory icon when keyboard

12 accessory becomes default on Android. -->	12 accessory becomes default on Android. -->

13 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_SCAN_NEW" file=" autofill/cc-generic.png" />	13 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_SCAN_NEW" file=" autofill/cc-generic.png" />

14 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_SCAN_NEW_KEYBOAR D_ACCESSORY" file="autofill/cc-generic.png" />	14 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_SCAN_NEW_KEYBOAR D_ACCESSORY" file="autofill/cc-generic.png" />

15 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_SETTINGS" file="aut ofill/cc-generic.png" />	15 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_SETTINGS" file="aut ofill/cc-generic.png" />

	16

	17 <!-- PaymentRequest image variants -->

	18 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_AMEX" file="auto fill/cc-generic.png" />

	19 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_DISCOVER" file=" autofill/cc-generic.png" />
	Mathieu 2016/04/28 16:41:44 meant to be all the same? meant to be all the same? please use gerrit instead 2016/04/28 16:59:05 Yes, meant to be all the same, because of the comm Show quoted text On 2016/04/28 16:41:44, Mathieu Perreault wrote: > meant to be all the same? Yes, meant to be all the same, because of the comment on line 10: "These are not used on desktop, only Android, so use a placeholder file." Mathieu 2016/04/28 17:10:00 Got it. It's a weird system... Show quoted text On 2016/04/28 16:59:05, Rouslan wrote: > On 2016/04/28 16:41:44, Mathieu Perreault wrote: > > meant to be all the same? > > Yes, meant to be all the same, because of the comment on line 10: > > "These are not used on desktop, only Android, so use a placeholder file." Got it. It's a weird system...
	20 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_GENERIC" file="a utofill/cc-generic.png" />

	21 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_MASTERCARD" file ="autofill/cc-generic.png" />

	22 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_PR_VISA" file="auto fill/cc-generic.png" />

16 </if>	23 </if>

17	24

18 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT" file="au tofill/credit_card_cvc_hint.png" />	25 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT" file="au tofill/credit_card_cvc_hint.png" />

19 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT_AMEX" fil e="autofill/credit_card_cvc_hint_amex.png" />	26 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT_AMEX" fil e="autofill/credit_card_cvc_hint_amex.png" />

20 <structure type="chrome_scaled_image" name="IDR_INFOBAR_AUTOFILL_CC" file="aut ofill/infobar_autofill_cc.png" />	27 <structure type="chrome_scaled_image" name="IDR_INFOBAR_AUTOFILL_CC" file="aut ofill/infobar_autofill_cc.png" />

21 <if expr="is_macosx or is_ios">	28 <if expr="is_macosx or is_ios">

22 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON" file= "autofill/autofill_tooltip_icon.png" />	29 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON" file= "autofill/autofill_tooltip_icon.png" />

23 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON_H" fil e="autofill/autofill_tooltip_icon_hover.png" />	30 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON_H" fil e="autofill/autofill_tooltip_icon_hover.png" />

24 </if>	31 </if>

25 </grit-part>	32 </grit-part>

OLD	NEW

« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.cc ('k') | no next file » | no next file with comments »