PaymentRequest specific card issuer icons

PaymentRequest specific card issuer icons

This patch changes CreditCard.getIssuerIconDrawableId() to return
PaymentRequest specific icons, because only PaymentRequest is using
these. The icons are larger than autofill icons. These files have been
run through optimize-png-files.sh. For now they are used only on
Android, the first platform to have PaymentRequest implementation.

BUG=603635
Committed: https://crrev.com/4e4540a18facf85aaf63f8f1f98b6f1ebeed7aa6
Cr-Commit-Position: refs/heads/master@{#390791}

[please use gerrit instead, 2016-04-28 03:58:00]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-04-28 03:58:00]

dfalcantara@, ptal.

The screenshot of the UI with these icons is in http://crbug.com/603635#c31.
hwi@ approved them in http://crbug.com/603635#c32.

[please use gerrit instead, 2016-04-28 03:59:22]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org

[please use gerrit instead, 2016-04-28 03:59:23]

estade@, ptal:

chrome/browser/autofill/android/personal_data_manager_android.cc
components/resources/autofill_scaled_resources.grdp

[gone, 2016-04-28 04:07:58]

Resources lgtm

[please use gerrit instead, 2016-04-28 15:59:57]

Description was changed from

==========
PaymentRequest specific card issuer icons

This patch changes CreditCard.getIssuerIconDrawableId() to return
PaymentRequest specific icons, because only PaymentRequest is using
these. The icons are larger than autofill icons. These files have been
run through optimize-png-files.sh. For now they are used only on
Android, the first platform to have PaymentRequest implementation.

BUG=603635
==========

to

==========
PaymentRequest specific card issuer icons

This patch changes CreditCard.getIssuerIconDrawableId() to return
PaymentRequest specific icons, because only PaymentRequest is using
these. The icons are larger than autofill icons. These files have been
run through optimize-png-files.sh. For now they are used only on
Android, the first platform to have PaymentRequest implementation.

BUG=603635
==========

[please use gerrit instead, 2016-04-28 15:59:57]

rouslan@chromium.org changed reviewers:
- estade@chromium.org

[please use gerrit instead, 2016-04-28 16:00:52]

rouslan@chromium.org changed reviewers:
+ mathp@chromium.org

[please use gerrit instead, 2016-04-28 16:00:53]

mathp@, ptal personal_data_manager_android.cc

[please use gerrit instead, 2016-04-28 16:02:31]

rouslan@chromium.org changed reviewers:
+ caitkp@chromium.org, estade@chromium.org

[please use gerrit instead, 2016-04-28 16:02:32]

caitkp@, ptal autofill_scaled_resources.grdp.

estade@ is ooo, I think.

[Mathieu, 2016-04-28 16:41:44]

Question below

personal_data_manager_android lgtm

https://codereview.chromium.org/1926903003/diff/1/components/resources/autofi...
File components/resources/autofill_scaled_resources.grdp (right):

https://codereview.chromium.org/1926903003/diff/1/components/resources/autofi...
components/resources/autofill_scaled_resources.grdp:19: <structure
type="chrome_scaled_image" name="IDR_AUTOFILL_PR_DISCOVER"
file="autofill/cc-generic.png" />
meant to be all the same?

[please use gerrit instead, 2016-04-28 16:59:05]

https://codereview.chromium.org/1926903003/diff/1/components/resources/autofi...
File components/resources/autofill_scaled_resources.grdp (right):

https://codereview.chromium.org/1926903003/diff/1/components/resources/autofi...
components/resources/autofill_scaled_resources.grdp:19: <structure
type="chrome_scaled_image" name="IDR_AUTOFILL_PR_DISCOVER"
file="autofill/cc-generic.png" />
On 2016/04/28 16:41:44, Mathieu Perreault wrote:
> meant to be all the same?

Yes, meant to be all the same, because of the comment on line 10:

"These are not used on desktop, only Android, so use a placeholder file."

[Mathieu, 2016-04-28 17:10:00]

https://codereview.chromium.org/1926903003/diff/1/components/resources/autofi...
File components/resources/autofill_scaled_resources.grdp (right):

https://codereview.chromium.org/1926903003/diff/1/components/resources/autofi...
components/resources/autofill_scaled_resources.grdp:19: <structure
type="chrome_scaled_image" name="IDR_AUTOFILL_PR_DISCOVER"
file="autofill/cc-generic.png" />
On 2016/04/28 16:59:05, Rouslan wrote:
> On 2016/04/28 16:41:44, Mathieu Perreault wrote:
> > meant to be all the same?
> 
> Yes, meant to be all the same, because of the comment on line 10:
> 
> "These are not used on desktop, only Android, so use a placeholder file."

Got it. It's a weird system...

[Cait (Slow), 2016-04-29 22:01:48]

components lgtm

[please use gerrit instead, 2016-04-29 22:07:07]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-04-29 22:07:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926903003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926903003/1

[commit-bot: I haz the power, 2016-04-29 22:52:19]

Description was changed from

==========
PaymentRequest specific card issuer icons

This patch changes CreditCard.getIssuerIconDrawableId() to return
PaymentRequest specific icons, because only PaymentRequest is using
these. The icons are larger than autofill icons. These files have been
run through optimize-png-files.sh. For now they are used only on
Android, the first platform to have PaymentRequest implementation.

BUG=603635
==========

to

==========
PaymentRequest specific card issuer icons

This patch changes CreditCard.getIssuerIconDrawableId() to return
PaymentRequest specific icons, because only PaymentRequest is using
these. The icons are larger than autofill icons. These files have been
run through optimize-png-files.sh. For now they are used only on
Android, the first platform to have PaymentRequest implementation.

BUG=603635
==========

[commit-bot: I haz the power, 2016-04-29 22:52:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:29:48]

Patchset 1 (id:??) landed as
https://crrev.com/4e4540a18facf85aaf63f8f1f98b6f1ebeed7aa6
Cr-Commit-Position: refs/heads/master@{#390791}

[commit-bot: I haz the power, 2016-04-30 18:03:18]

Description was changed from

==========
PaymentRequest specific card issuer icons

This patch changes CreditCard.getIssuerIconDrawableId() to return
PaymentRequest specific icons, because only PaymentRequest is using
these. The icons are larger than autofill icons. These files have been
run through optimize-png-files.sh. For now they are used only on
Android, the first platform to have PaymentRequest implementation.

BUG=603635
==========

to

==========
PaymentRequest specific card issuer icons

This patch changes CreditCard.getIssuerIconDrawableId() to return
PaymentRequest specific icons, because only PaymentRequest is using
these. The icons are larger than autofill icons. These files have been
run through optimize-png-files.sh. For now they are used only on
Android, the first platform to have PaymentRequest implementation.

BUG=603635

Committed: https://crrev.com/4e4540a18facf85aaf63f8f1f98b6f1ebeed7aa6
Cr-Commit-Position: refs/heads/master@{#390791}
==========