DescriptionRevert of Add next_version_mini_installer target. (patchset #6 id:100001 of https://codereview.chromium.org/1902233003/ )
Reason for revert:
Broke the Win builder: https://build.chromium.org/p/chromium/builders/Win/builds/42817
Failed step checkbins:
Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /DYNAMICBASE... FAIL
Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /NXCOMPAT... PASS
Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /SAFESEH... PASS
Original issue's description:
> Add next_version_mini_installer target.
>
> This target generates next_version_mini_installer.exe, which has a
> higher version number than mini_installer.exe. This new installer
> will be used to test various update scenarios (using test_installer.py).
>
> next_version_mini_installer needs to be added to the list of
> dependencies of MiniInstallerTest before tests start using it.
> (build/scripts/slave/recipe_modules/chromium_tests/steps.py)
>
> BUG=605177
TBR=grt@chromium.org,dpranke@chromium.org,zmin@chromium.org,eclipse0072015@gmail.com,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605177
Committed: https://crrev.com/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9
Cr-Commit-Position: refs/heads/master@{#390191}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|