Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1926893002: Revert of Add next_version_mini_installer target. (Closed)

Created:
4 years, 7 months ago by Justin Donnelly
Modified:
4 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add next_version_mini_installer target. (patchset #6 id:100001 of https://codereview.chromium.org/1902233003/ ) Reason for revert: Broke the Win builder: https://build.chromium.org/p/chromium/builders/Win/builds/42817 Failed step checkbins: Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /DYNAMICBASE... FAIL Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /NXCOMPAT... PASS Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /SAFESEH... PASS Original issue's description: > Add next_version_mini_installer target. > > This target generates next_version_mini_installer.exe, which has a > higher version number than mini_installer.exe. This new installer > will be used to test various update scenarios (using test_installer.py). > > next_version_mini_installer needs to be added to the list of > dependencies of MiniInstallerTest before tests start using it. > (build/scripts/slave/recipe_modules/chromium_tests/steps.py) > > BUG=605177 TBR=grt@chromium.org,dpranke@chromium.org,zmin@chromium.org,eclipse0072015@gmail.com,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605177 Committed: https://crrev.com/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9 Cr-Commit-Position: refs/heads/master@{#390191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -110 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M build/all.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 2 chunks +1 line, -39 lines 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/installer/mini_installer/generate_next_version_mini_installer.py View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/installer/test/alternate_version_generator_main.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Justin Donnelly
Created Revert of Add next_version_mini_installer target.
4 years, 7 months ago (2016-04-27 21:22:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926893002/1
4 years, 7 months ago (2016-04-27 21:22:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 21:23:15 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:13:17 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9
Cr-Commit-Position: refs/heads/master@{#390191}

Powered by Google App Engine
This is Rietveld 408576698