Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: dashboard/dashboard/elements/bug-info.html

Issue 1926883002: [Polymer 1.0] Convert bug-info and bug-info-span to Polymer 1.0. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dashboard/dashboard/elements/bug-info-span.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/elements/bug-info.html
diff --git a/dashboard/dashboard/elements/bug-info.html b/dashboard/dashboard/elements/bug-info.html
index 42076fb2f10d868fd915e915e77824c8a00b7285..05fe73d892add8220ad0648b36d82f68bf9272d4 100644
--- a/dashboard/dashboard/elements/bug-info.html
+++ b/dashboard/dashboard/elements/bug-info.html
@@ -7,7 +7,7 @@ found in the LICENSE file.
<link rel="import" href="/dashboard/elements/bisect-button.html">
-<polymer-element name="bug-info">
+<dom-module id="bug-info">
<template>
<style>
#container {
@@ -28,6 +28,16 @@ found in the LICENSE file.
font-weight: bold;
color: red;
}
+
+ li {
+ display: inline;
+ /* Width of a space is 0.25em. */
+ padding: 0 0.15em 0 0.4em;
+ }
+
+ li + li {
+ border-left: solid 1px;
+ }
</style>
<div id="container" style="display:none">
<div class="info-bar">
@@ -37,14 +47,15 @@ found in the LICENSE file.
<span id="warning" class="warning"></span>
<bisect-button id="bisect" class="mini"></bisect-button>
</p>
- <template bind if="{{ownerInfo}}">
+ <template is="dom-if" if="{{ownerInfo}}">
<p>
Owners:
- <template repeat="{{owner, index in ownerInfo}}">
- <!--TODO(chrisphan): Link this to bug comment dialog.-->
- <a href="#" onclick="return false;">{{owner.email}}</a>
- <span hidden?="{{index == ownerInfo.length - 1}}"> | </span>
- </template>
+ <ul>
+ <template is="dom-repeat" items="{{ownerInfo}}">
+ <!--TODO(chrisphan): Link this to bug comment dialog.-->
+ <li><a href="#" onclick="return false;">{{item.email}}</a></li>
+ </template>
+ </ul>
</p>
</template>
</div>
@@ -52,9 +63,12 @@ found in the LICENSE file.
</template>
<script>
'use strict';
- Polymer('bug-info', {
- alertsTable: null,
- bugId: null,
+ Polymer({
+ is: 'bug-info',
+ properties: {
+ alertsTable: { value: null},
+ bugId: { value: null},
+ }
/**
* Initializes this element.
@@ -153,4 +167,4 @@ found in the LICENSE file.
}
});
</script>
-</polymer-element>
+</dom-module>
« no previous file with comments | « no previous file | dashboard/dashboard/elements/bug-info-span.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698