content/browser/media/capture/image_capture_context.cc - Issue 1926873002: MediaStream Image Capture (3): Adding mojo and browser impl for dummy takePhoto().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/media/capture/image_capture_context.cc

Issue 1926873002: MediaStream Image Capture (3): Adding mojo and browser impl for dummy takePhoto(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reillyg@ comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/media/capture/image_capture_context.h ('k') | content/browser/media/capture/image_capture_impl.h » ('j') | third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/media/capture/image_capture_context.h"

	6

	7 #include "content/browser/media/capture/image_capture_impl.h"

	8

	9 namespace content {

	10

	11 ImageCaptureContext::ImageCaptureContext() {}

	12

	13 ImageCaptureContext::~ImageCaptureContext() {}

	14

	15 void ImageCaptureContext::CreateService(

	16 mojo::InterfaceRequest<blink::mojom::ImageCapture> request) {

	17 services_.push_back(std::unique_ptr<ImageCaptureImpl>(
	Reilly Grant (use Gerrit) 2016/04/28 01:09:57 Sorry, I should have been clearer. Now that ImageC Sorry, I should have been clearer. Now that ImageCaptureImpl has a StrongBinding you don't need to maintain this vector. The ImageCaptureImpl instances are owned by the StrongBinding they contain and will be destroyed when the pipe is closed by the renderer. mcasas 2016/04/28 19:35:49 Ah OK, then I'm removing ImageCaptureContext altog Show quoted text On 2016/04/28 01:09:57, Reilly Grant wrote: > Sorry, I should have been clearer. Now that ImageCaptureImpl has a StrongBinding > you don't need to maintain this vector. The ImageCaptureImpl instances are owned > by the StrongBinding they contain and will be destroyed when the pipe is closed > by the renderer. Ah OK, then I'm removing ImageCaptureContext altogether.
	18 new ImageCaptureImpl(std::move(request))));

	19 }

	20

	21 } // namespace content

OLD	NEW