third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html - Issue 1926873002: MediaStream Image Capture (3): Adding mojo and browser impl for dummy takePhoto().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html

Issue 1926873002: MediaStream Image Capture (3): Adding mojo and browser impl for dummy takePhoto(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: haraken@ comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/media/capture/image_capture_impl.cc ('K') | « content/content_browser.gypi ('k') | third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src=../../resources/testharness.js></script>

	3 <script src=../../resources/testharnessreport.js></script>

	4 <body>

	5 <canvas id='canvas0' width=10 height=10/>

	6 </body>

	7 <script>

	8

	9 // This test verifies ImageCapture's takePhoto().

	10

	11 var test = async_test(function() {

	12 var canvas0 = document.getElementById('canvas0');

	13 var context0 = canvas0.getContext("2d");

	14 context0.fillStyle = "red";

	15 context0.fillRect(0, 0, 10, 10);

	16

	17 var stream = canvas0.captureStream();

	18

	19 var capturer = new ImageCapture(stream.getVideoTracks()[0]);

	20

	21 capturer.takePhoto()
	miu 2016/05/02 21:44:51 This has probably already been decided elsewhere, This has probably already been decided elsewhere, and I know I don't have all the context, but: It seems inaccurate to name the method "takePhoto" since photo is short for photograph and implies some kind of image capture of the real world. Suggestion: How about "takeFrameSnapshot" or just "takeSnapshot"? mcasas 2016/05/02 22:03:35 There are two methods in this API: grabFrame(), wh Show quoted text On 2016/05/02 21:44:51, miu wrote: > This has probably already been decided elsewhere, and I know I don't have all > the context, but: It seems inaccurate to name the method "takePhoto" since photo > is short for photograph and implies some kind of image capture of the real > world. Suggestion: How about "takeFrameSnapshot" or just "takeSnapshot"? There are two methods in this API: grabFrame(), which essentially grabs a VideoFrame out of the MediaStream Track [1], and takePhoto() which will take momentarily control of the VideoCaptureDevice to produce a photo, eventually with larger resolution etc. [1] https://code.google.com/p/chromium/codesearch#search/&sq=package:chromium&typ...
	22 .then(blob => {

	23 assert_true(blob.type.length > 0);

	24 assert_true(blob.size > 0);

	25 this.done();

	26 })

	27 .catch(error => {

	28 assert_unreached('Error during takePhoto(): '+ error);

	29 });

	30 }, 'exercises the ImageCapture API takePhoto().');

	31

	32 </script>

OLD	NEW