Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: src/api.cc

Issue 1926863003: Make Isolate::GetStackSample API support simulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/profiler/sampler.h » ('j') | src/profiler/sampler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 47fc1ce1b2f62ba22dd739aeba225c14da1b9230..41517249624e7b716ef538f5a7a32b50c23819d7 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -7522,7 +7522,14 @@ bool Isolate::GetHeapObjectStatisticsAtLastGC(
void Isolate::GetStackSample(const RegisterState& state, void** frames,
size_t frames_limit, SampleInfo* sample_info) {
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
- i::TickSample::GetStackSample(isolate, state, i::TickSample::kSkipCEntryFrame,
+ RegisterState regs;
+ regs.pc = state.pc;
alph 2016/04/29 18:55:06 nit: you don't need to do the copy for non-simulat
lpy 2016/04/29 19:51:58 Done.
+ regs.sp = state.sp;
+ regs.fp = state.fp;
+#if defined(USE_SIMULATOR)
+ i::SimulatorHelper::FillRegisters(isolate, &regs);
+#endif
+ i::TickSample::GetStackSample(isolate, regs, i::TickSample::kSkipCEntryFrame,
frames, frames_limit, sample_info);
}
« no previous file with comments | « no previous file | src/profiler/sampler.h » ('j') | src/profiler/sampler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698