Make Isolate::GetStackSample API support simulator

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 7504 matching lines @@
   object_statistics->object_sub_type_ = object_sub_type;
   object_statistics->object_count_ = object_count;
   object_statistics->object_size_ = object_size;
   return true;
 }
 
 
 void Isolate::GetStackSample(const RegisterState& state, void** frames,
                              size_t frames_limit, SampleInfo* sample_info) {
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
+#if defined(USE_SIMULATOR)
+  RegisterState regs;
+  regs.pc = state.pc;
+  regs.sp = state.sp;
+  regs.fp = state.fp;
+  i::SimulatorHelper::FillRegisters(isolate, &regs);
+  i::TickSample::GetStackSample(isolate, regs, i::TickSample::kSkipCEntryFrame,
+                                frames, frames_limit, sample_info);
+#else
   i::TickSample::GetStackSample(isolate, state, i::TickSample::kSkipCEntryFrame,

[alph, 2016/04/29 20:59:57]

You don't have to copy this line twice. Just make:

#else
  const RegisterState& regs = state;
#endif
  i::TickSample::GetStackSample...

[lpy, 2016/04/29 21:43:10]

Done.

                                 frames, frames_limit, sample_info);
+#endif
 }
 
 
 void Isolate::SetEventLogger(LogEventCallback that) {
   // Do not overwrite the event logger if we want to log explicitly.
   if (i::FLAG_log_internal_timer_events) return;
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
   isolate->set_event_logger(that);
 }
 
@@ skipping 1301 matching lines @@
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 }  // namespace internal
 }  // namespace v8