Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1926813007: Update Win toolchain (Closed)

Created:
4 years, 7 months ago by mtklein_C
Modified:
4 years, 7 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update Win toolchain I believe this now correctly updates us to VS 2015 update 2. CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Win-MSVC-x86-Debug-VS2015-Trybot https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=3c710fd7f4df8ec24fde62681536fad21be2751c BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926813007 Committed: https://skia.googlesource.com/skia/+/d1adec187069f9706e7311815e8232dd8307e995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M infra/bots/win_toolchain_hash.json View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
mtklein_C
4 years, 7 months ago (2016-04-28 17:39:57 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926813007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926813007/1
4 years, 7 months ago (2016-04-28 17:46:19 UTC) #7
borenet
LGTM
4 years, 7 months ago (2016-04-28 17:48:30 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 18:00:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926813007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926813007/1
4 years, 7 months ago (2016-04-28 18:01:41 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 18:02:39 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d1adec187069f9706e7311815e8232dd8307e995

Powered by Google App Engine
This is Rietveld 408576698