Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1926813005: Remove MessageLoop::PostNonNestableDelayedTask(). (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessageLoop::PostNonNestableDelayedTask(). Deprecated in favor of TaskRunner interfaces. Only callers left are unit tests and iOS. Fix iOS. BUG=465354 Committed: https://crrev.com/83ccc3a455e327b1abe2a19090506c3a9a17724e Cr-Commit-Position: refs/heads/master@{#390427}

Patch Set 1 #

Patch Set 2 : ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -42 lines) Patch
M base/message_loop/message_loop.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M base/message_loop/message_loop_test.h View 2 chunks +2 lines, -6 lines 0 comments Download
M base/message_loop/message_loop_test.cc View 3 chunks +7 lines, -22 lines 0 comments Download
M ios/web/web_thread_impl.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Lei Zhang
4 years, 7 months ago (2016-04-28 01:43:34 UTC) #4
marq (ping after 24h)
lgtm
4 years, 7 months ago (2016-04-28 07:13:53 UTC) #5
Sami
Thanks for the cleanup, lgtm.
4 years, 7 months ago (2016-04-28 09:37:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926813005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926813005/20001
4 years, 7 months ago (2016-04-28 18:24:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 18:28:56 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:19:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83ccc3a455e327b1abe2a19090506c3a9a17724e
Cr-Commit-Position: refs/heads/master@{#390427}

Powered by Google App Engine
This is Rietveld 408576698