Add --allow-downgrade argument for incremental installer.

Add --allow-downgrade argument for incremental installer.

BUG=Internal b/28374781

Committed: https://crrev.com/05017cbc524ecb739af590d19b932333722261f2
Cr-Commit-Position: refs/heads/master@{#391992}

[Simeon, 2016-04-27 17:33:52]

sanfin@chromium.org changed reviewers:
+ agrieve@chromium.org, mbjorge@chromium.org, sanfin@chromium.org,
tsunghung@chromium.org

[Simeon, 2016-04-27 17:33:53]

I'm looking into using the incremental install methods for building and running
the Cast for Android TV apk: b/28374781.

One issue I came across that made it difficult was that the version number could
be lower than the one on the device (which could be because a previous apk's
version number was calculated wrong, or because we switched to new logic for
tracking incremental build numbers, or because, as is the case now, we are using
dummy version numbers until we integrate the build scripts better for the
Android platform). The Install() methods in device_utils.py already provide the
option to pass in an argument to ignore the version number, so it didn't take
much to add it as a passable argument to the script. This allows anyone blocked
by version number logic, as we on the Cast team are currently, to bypass this
error by explicitly passing --allow-downgrade to the incremental install script.

[agrieve, 2016-04-27 18:00:29]

On 2016/04/27 17:33:53, Simeon wrote:
> I'm looking into using the incremental install methods for building and
running
> the Cast for Android TV apk: b/28374781.
> 
> One issue I came across that made it difficult was that the version number
could
> be lower than the one on the device (which could be because a previous apk's
> version number was calculated wrong, or because we switched to new logic for
> tracking incremental build numbers, or because, as is the case now, we are
using
> dummy version numbers until we integrate the build scripts better for the
> Android platform). The Install() methods in device_utils.py already provide
the
> option to pass in an argument to ignore the version number, so it didn't take
> much to add it as a passable argument to the script. This allows anyone
blocked
> by version number logic, as we on the Cast team are currently, to bypass this
> error by explicitly passing --allow-downgrade to the incremental install
script.

I'd like to have incremental install "just work" as much as possible. I think
it'd be fine to just always pass allow_downgrade=True.

[Simeon, 2016-05-05 21:45:25]

ping

[AndyWu, 2016-05-05 21:57:29]

lgtm

[agrieve, 2016-05-06 00:43:59]

On 2016/05/05 21:57:29, AndyWu wrote:
> lgtm

lgtm

[Simeon, 2016-05-06 01:03:09]

The CQ bit was checked by sanfin@chromium.org

[commit-bot: I haz the power, 2016-05-06 01:03:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926813002/40001

[commit-bot: I haz the power, 2016-05-06 02:40:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-06 02:42:43]

Description was changed from

==========
Add --allow-downgrade argument for incremental installer.

BUG=Internal b/28374781
==========

to

==========
Add --allow-downgrade argument for incremental installer.

BUG=Internal b/28374781

Committed: https://crrev.com/05017cbc524ecb739af590d19b932333722261f2
Cr-Commit-Position: refs/heads/master@{#391992}
==========

[commit-bot: I haz the power, 2016-05-06 02:42:44]

Patchset 3 (id:??) landed as
https://crrev.com/05017cbc524ecb739af590d19b932333722261f2
Cr-Commit-Position: refs/heads/master@{#391992}