👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata

net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java

Index: net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java
diff --git a/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java b/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java
index e0e67d58adf09e22dd14a3681f4406535f78abc8..9651e40a8d9aabffc724806bff5fa4e122df478b 100644
--- a/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java
+++ b/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java
@@ -8,6 +8,7 @@ import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.content.ServiceConnection;
+import android.os.Environment;
 import android.os.IBinder;
 import android.os.RemoteException;
 
@@ -194,19 +195,17 @@ public class EmbeddedTestServer {
      *  On returning, the server is ready for use.
      *
      *  @param context The context in which the server will run.
-     *  @param directory The directory from which files should be served.
+     *  @param directory The directory from which files should be served. This must be
+     *      Environment.getExternalStorageDirectory().
      *  @return The created server.
      */
     public static EmbeddedTestServer createAndStartFileServer(Context context, File directory)
             throws InterruptedException {
-        EmbeddedTestServer server = new EmbeddedTestServer();
-        server.initializeNative(context);
-        server.serveFilesFromDirectory(directory);
-        if (!server.start()) {
-            throw new EmbeddedTestServerFailure(
-                    "Failed to start serving files from " + directory.getPath());
+        // TODO(agrieve): Update all callers to use createAndStartDefaultServer() directly.

[jbudorick, 2016/04/27 19:59:01]

I've been meaning to do this but haven't gotten around to it :/

+        if (!directory.equals(Environment.getExternalStorageDirectory())) {
+            throw new IllegalArgumentException("Expected directory to be ExternalStorageDirectory");
         }
-        return server;
+        return createAndStartDefaultServer(context);
     }
 
     /** Create and initialize a server with the default handlers.