components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java - Issue 1926793002: 👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java

Issue 1926793002: 👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Was passing due to stale files on my /sdcard. Now should be fixed. QuicTestServer had a ref to e::a… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/quic_test_server.cc ('k') | components/cronet/android/test/src/org/chromium/net/NativeTestServer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java

diff --git a/components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java b/components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java

index bf20bc0f727b806b24e45efeb2d2d7fae6cadf29..dafc97be21103b77ed90edaf4f996db45e0dd9a5 100644

--- a/components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java

+++ b/components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java

@@ -5,6 +5,7 @@

package org.chromium.net;

import org.chromium.base.annotations.JNINamespace;

+import org.chromium.base.test.util.UrlUtils;

/**

* A Java wrapper to supply a net::MockCertVerifier which can be then passed

@@ -22,8 +23,8 @@ public class MockCertVerifier {

* @return a pointer to the newly created net::MockCertVerifier.

public static long createMockCertVerifier(String[] certs) {

- return nativeCreateMockCertVerifier(certs);

+ return nativeCreateMockCertVerifier(certs, UrlUtils.getIsolatedTestRoot());

}

- private static native long nativeCreateMockCertVerifier(String[] certs);

+ private static native long nativeCreateMockCertVerifier(String[] certs, String testDataDir);

}