Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2507)

Unified Diff: base/base_paths_android.cc

Issue 1926793002: 👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Was passing due to stale files on my /sdcard. Now should be fixed. QuicTestServer had a ref to e::a… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base_paths_android.cc
diff --git a/base/base_paths_android.cc b/base/base_paths_android.cc
index ca58179b6782fdc4d9ec283df14b4d97b5e688dc..8a400e5bd14ae9e29c9350bafe0c10fc163604f0 100644
--- a/base/base_paths_android.cc
+++ b/base/base_paths_android.cc
@@ -38,8 +38,10 @@ bool PathProviderAndroid(int key, FilePath* result) {
case base::DIR_MODULE:
return base::android::GetNativeLibraryDirectory(result);
case base::DIR_SOURCE_ROOT:
- // This const is only used for tests.
- return base::android::GetExternalStorageDirectory(result);
+ // Used only by tests.
+ // In that context, hooked up via base/test/test_support_android.cc.
+ NOTIMPLEMENTED();
+ return false;
case base::DIR_USER_DESKTOP:
// Android doesn't support GetUserDesktop.
NOTIMPLEMENTED();
« no previous file with comments | « no previous file | base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698