Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5290)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/chrome_paths.cc

Issue 1926793002: 👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: some review fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/local/device/local_device_gtest_run.py ('K') | « build/apk_test.gypi ('k') | net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_paths.cc
diff --git a/chrome/common/chrome_paths.cc b/chrome/common/chrome_paths.cc
index f4e119db21536639646f55aaf0b4db586721d280..2b7e4e30ceee9cb01de57fabeee8fa260b0d8deb 100644
--- a/chrome/common/chrome_paths.cc
+++ b/chrome/common/chrome_paths.cc
@@ -441,7 +441,7 @@ bool PathProvider(int key, base::FilePath* result) {
#if defined(OS_ANDROID)
// On Android, our tests don't have permission to write to DIR_MODULE.
// gtest/test_runner.py pushes data to external storage.
- if (!PathService::Get(base::DIR_ANDROID_EXTERNAL_STORAGE, &cur))
+ if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))
return false;
#else
if (!PathService::Get(base::DIR_MODULE, &cur))
« build/android/pylib/local/device/local_device_gtest_run.py ('K') | « build/apk_test.gypi ('k') | net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698