build/android/pylib/remote/device/remote_device_test_run.py - Issue 1926793002: 👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/remote/device/remote_device_test_run.py

Issue 1926793002: 👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: some review fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/local/device/local_device_gtest_run.py ('K') | « build/android/pylib/local/device/local_device_instrumentation_test_run.py ('k') | build/apk_test.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/remote/device/remote_device_test_run.py

diff --git a/build/android/pylib/remote/device/remote_device_test_run.py b/build/android/pylib/remote/device/remote_device_test_run.py

index ec29b554464dc4850d10a7421eb568fd0875e30c..c97e3b832d43b76cc0cd27e4e11e7d629657416a 100644

--- a/build/android/pylib/remote/device/remote_device_test_run.py

+++ b/build/android/pylib/remote/device/remote_device_test_run.py

@@ -230,6 +230,8 @@ class RemoteDeviceTestRun(test_run.TestRun):

self._app_id = self._UploadAppToDevice(app_path)

+ # TODO(agrieve): If AMP is ever ressurected, this needs to be changed to put

+ # test files under /sdcard/gtestdata. http://crbug.com/607169

data_deps = self._test_instance.GetDataDependencies()

if data_deps:

with tempfile.NamedTemporaryFile(suffix='.zip') as test_with_deps: