👔 Move side-loaded test data /sdcard -> /sdcard/gtestdata

base/base_paths_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines base::PathProviderAndroid which replaces base::PathProviderPosix for
 // Android in base/path_service.cc.
 
 #include <limits.h>
 #include <unistd.h>
 
@@ skipping 22 matching lines @@
       return true;
     }
     case base::FILE_MODULE:
       // dladdr didn't work in Android as only the file name was returned.
       NOTIMPLEMENTED();
       return false;
     case base::DIR_MODULE:
       return base::android::GetNativeLibraryDirectory(result);
     case base::DIR_SOURCE_ROOT:
       // This const is only used for tests.
-      return base::android::GetExternalStorageDirectory(result);
+      if (!base::android::GetExternalStorageDirectory(result))
+        return false;
+      *result = result->Append(FILE_PATH_LITERAL("gtestdata"));

[jbudorick, 2016/04/27 19:59:01]

What's the motivation behind putting this in "gtestdata" rather than using the
external storage directory directly? This, tbh, is the scariest part of this
change.

[jbudorick, 2016/04/27 20:00:30]

(also, in the event we keep it, "gtestdata" is a bad name. Instrumentation tests
use this, too.)

[agrieve, 2016/04/27 20:26:31]

chromium_test_root?

[agrieve, 2016/04/27 20:26:31]

It's to avoid wiping the entire /sdcard when running tests. Alternatively, we
could have some custom code that deletes all files except directories that start
with a capital letter. 

Still feels like just putting the test data in a custom directory is the nicer
way to go though. I've on occasion used my personal android phone to run a test,
and I'd be upset if it wiped my sdcard.

[jbudorick, 2016/04/27 20:41:36]

eh, I'd rather have our own sdcard subdirectory than something like this.
I would generally advise against this. I do try to warn people whenever I tell
them to do something that will nuke their SD card (and the test runner doesn't
do so, obviously).

+      return true;
     case base::DIR_USER_DESKTOP:
       // Android doesn't support GetUserDesktop.
       NOTIMPLEMENTED();
       return false;
     case base::DIR_CACHE:
       return base::android::GetCacheDirectory(result);
     case base::DIR_ANDROID_APP_DATA:
       return base::android::GetDataDirectory(result);
     case base::DIR_ANDROID_EXTERNAL_STORAGE:
       return base::android::GetExternalStorageDirectory(result);
     default:
       // Note: the path system expects this function to override the default
       // behavior. So no need to log an error if we don't support a given
       // path. The system will just use the default.
       return false;
   }
 }
 
 }  // namespace base