Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1926773003: [esnext] implement StringPad spec changes from March TC39 meeting (Closed)

Created:
4 years, 7 months ago by caitp (gmail)
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[esnext] implement StringPad spec changes from March TC39 meeting Return the empty string from StringPad if the filler argument is the empty string, effectively returning the string unchanged in StringPadStart and StringPadEnd. ``` "foo".padStart(100000, "") -> "foo" ``` BUG=v8:4957, v8:4954 LOG=N R=littledan@chromium.org Committed: https://crrev.com/ff956f4dee0a7c5b50916e04e02444e46931ce7e Cr-Commit-Position: refs/heads/master@{#35837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M src/js/harmony-string-padding.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/harmony-string-pad-end.js View 1 chunk +12 lines, -1 line 0 comments Download
M test/mjsunit/harmony/harmony-string-pad-start.js View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
caitp (gmail)
PTAL for quick fix
4 years, 7 months ago (2016-04-27 21:33:11 UTC) #1
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-04-27 21:36:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926773003/1
4 years, 7 months ago (2016-04-27 21:42:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 22:02:36 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff956f4dee0a7c5b50916e04e02444e46931ce7e
Cr-Commit-Position: refs/heads/master@{#35837}

Powered by Google App Engine
This is Rietveld 408576698