Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1926763002: Fixes for SingleContextManager after experiments with two big codebases. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes for SingleContextManager after experiments with two big codebases. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/78ca9cc10b02cce2bd0a6d1a8b34f3bf95ea3985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/single_context_manager.dart View 6 chunks +15 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/plugin/resolver_provider.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-04-27 15:39:58 UTC) #1
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-04-27 15:43:16 UTC) #2
scheglov
4 years, 7 months ago (2016-04-27 15:46:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
78ca9cc10b02cce2bd0a6d1a8b34f3bf95ea3985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698