platform_tools/android/gyp/skia_android.gypi - Issue 1926743002: Upgrade Android Gradle plugins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/gyp/skia_android.gypi

Issue 1926743002: Upgrade Android Gradle plugins (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/gyp/skia_android.gypi

diff --git a/platform_tools/android/gyp/skia_android.gypi b/platform_tools/android/gyp/skia_android.gypi

index 7767183bd1ee18d306ced39b4828ceaf50725ada..29342d97fdb52e50028cd926a75ee492d7cd4961 100644

--- a/platform_tools/android/gyp/skia_android.gypi

+++ b/platform_tools/android/gyp/skia_android.gypi

@@ -38,10 +38,12 @@

'android_arch%': "mips64",

'android_variant%': "mips64",

}],

- [ 'android_buildtype == "Release"', {

- 'android_apk_suffix': "release.apk",

- }, {

+ [ 'android_buildtype == "Debug"', {

'android_apk_suffix': "debug.apk",

+ }, {

+ # This also accounts for Release_Developer BUILDTYPE

+ 'android_buildtype': "Release",

+ 'android_apk_suffix': "release.apk",

}],