Issue 192673002: Merge the "Compute Minus Zero Checks" phase into the range analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192673002: Merge the "Compute Minus Zero Checks" phase into the range analysis. (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Merge the "Compute Minus Zero Checks" phase into the range analysis. It is not safe to access the range for an SSA value after range analysis. BUG=v8:3204 LOG=y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19751

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+113 lines, -208 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
D	src/hydrogen-minus-zero.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	src/hydrogen-minus-zero.cc	View	1 chunk	+0 lines, -136 lines	0 comments	Download
M	src/hydrogen-range-analysis.h	View	2 chunks	+14 lines, -1 line	0 comments	Download
M	src/hydrogen-range-analysis.cc	View	2 chunks	+98 lines, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Next step towards fixing the epic range analysis bug...

6 years, 9 months ago (2014-03-10 11:39:21 UTC) #1

Benedikt Meurer

6 years, 9 months ago (2014-03-10 11:49:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19751 (presubmit successful).