Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 1926723002: Remove bogus DCHECKs in enumeration processing. (Closed)

Created:
4 years, 7 months ago by Guido Urdaneta
Modified:
4 years, 7 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove bogus DCHECKs in enumeration processing. These DCHECKs are intended to ensure that only one reply per device-type per request is received from the browser. However, the browser can send multiple replies if a device is added or removed before the request is completed. This is no problem, as the latest reply is used in case of multiple replies. The bug is difficult to simulate in an automated test because it involves addition and removal of devices with precise timing, but it is very easy to reproduce manually. BUG=607179 Committed: https://crrev.com/039cd143ff3e7d6c58fc8a6e85029d4f19e58b7d Cr-Commit-Position: refs/heads/master@{#390360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/renderer/media/user_media_client_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Guido Urdaneta
Hi, another tiny CL, but this one actually does something :)
4 years, 7 months ago (2016-04-27 14:58:08 UTC) #2
perkj_chrome
lgtm
4 years, 7 months ago (2016-04-28 12:08:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926723002/1
4 years, 7 months ago (2016-04-28 12:11:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 13:02:11 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/039cd143ff3e7d6c58fc8a6e85029d4f19e58b7d
Cr-Commit-Position: refs/heads/master@{#390360}

Powered by Google App Engine
This is Rietveld 408576698