Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 1926703002: ppapi: PPB_VpnProvider: Define PPAPI messages (Closed)

Created:
4 years, 7 months ago by adrian.belgun
Modified:
4 years, 7 months ago
Reviewers:
bbudge, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@vpn-api-headers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ppapi: PPB_VpnProvider: Define PPAPI messages BUG=506490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M ppapi/proxy/ppapi_messages.h View 1 chunk +29 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
adrian.belgun
dcheng: Please review changes in ppapi_messages.h
4 years, 7 months ago (2016-04-27 14:57:40 UTC) #2
dcheng
What's the patch that uses them? It's impossible to review IPCs in isolation, since part ...
4 years, 7 months ago (2016-04-27 17:18:59 UTC) #3
bbudge
Now that you've split the IDL / boilerplate into a simpler API patch, you can ...
4 years, 7 months ago (2016-04-27 17:30:08 UTC) #4
adrian.belgun
4 years, 7 months ago (2016-04-28 08:35:26 UTC) #5
On 2016/04/27 17:30:08, bbudge wrote:
> Now that you've split the IDL / boilerplate into a simpler API patch, you can
do
> the entire implementation as a single patch. We should land the API first to
> reduce review churn on subsequent patches.
> 
> It's possible to implement in two patches, by creating the resource, but
> stubbing out the API. The second patch would implement the host and the
> messages. Also some tests.
> 
> Locally, you should have a branch for each change, and keep them merged to
make
> sure everything makes sense and works correctly as previous patches change
from
> review.

Merged this back into the Resource implementation. Closing this.

Patches that use changes in ppapi_messages.h.
Resource: https://codereview.chromium.org/1931513002/
Resource Host: https://codereview.chromium.org/1735473002/

Powered by Google App Engine
This is Rietveld 408576698