Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 19267023: Do not report unessential weak references in heap snapshot. (Closed)

Created:
7 years, 5 months ago by alph
Modified:
7 years, 5 months ago
Reviewers:
yurys, Toon Verwaest, loislo
CC:
v8-dev
Visibility:
Public.

Description

Do not report unessential weak references in heap snapshot. R=verwaest@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15731

Patch Set 1 #

Patch Set 2 : Updated tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -25 lines) Patch
M src/heap-snapshot-generator.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 chunks +2 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
alph
Ilya, Toon, could you please take a look.
7 years, 5 months ago (2013-07-16 18:12:14 UTC) #1
yurys
lgtm
7 years, 5 months ago (2013-07-16 18:27:12 UTC) #2
Toon Verwaest
Can we have a test for this?
7 years, 5 months ago (2013-07-16 19:31:20 UTC) #3
alph
On 2013/07/16 19:31:20, Toon Verwaest wrote: > Can we have a test for this? We ...
7 years, 5 months ago (2013-07-16 19:55:58 UTC) #4
Toon Verwaest
sgtm
7 years, 5 months ago (2013-07-16 20:55:55 UTC) #5
alph
Toon, please take a look.
7 years, 5 months ago (2013-07-17 16:48:34 UTC) #6
Toon Verwaest
lgtm
7 years, 5 months ago (2013-07-17 16:56:29 UTC) #7
alph
7 years, 5 months ago (2013-07-17 18:23:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r15731 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698