Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: src/compiler.h

Issue 1926693003: [compiler] Remove deprecated CompilationJob status. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-rename-compilation-job
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index 04cc44e75805562e827d7f46230e023257032f79..66fa865d6fe02c42334ccfafb8bbbad20e901341 100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -568,9 +568,11 @@ class CompilationInfo {
// 2) OptimizeGraph: Runs concurrently. No heap allocation or handle derefs.
// 3) GenerateCode: Runs on main thread. No dependency changes.
//
-// Each of the three phases can either fail, bail-out to full code generator or
-// succeed. Apart from their return value, the status of the phase last run can
-// be checked using {last_status()} as well.
+// Each of the three phases can either fail or succeed. Apart from their return
+// value, the status of the phase last run can be checked using {last_status()}
+// as well. When failing we distinguish between the following levels:
+// a) AbortOptimization: Persistent failure, disable future optimization.
+// b) RetryOptimzation: Transient failure, try again next time.
// TODO(mstarzinger): Make CompilationInfo base embedded.
class CompilationJob {
public:
@@ -578,9 +580,7 @@ class CompilationJob {
: info_(info), compiler_name_(compiler_name), last_status_(SUCCEEDED) {}
virtual ~CompilationJob() {}
- enum Status {
- FAILED, BAILED_OUT, SUCCEEDED
- };
+ enum Status { FAILED, SUCCEEDED };
MUST_USE_RESULT Status CreateGraph();
MUST_USE_RESULT Status OptimizeGraph();
@@ -592,12 +592,12 @@ class CompilationJob {
Status RetryOptimization(BailoutReason reason) {
info_->RetryOptimization(reason);
- return SetLastStatus(BAILED_OUT);
+ return SetLastStatus(FAILED);
}
Status AbortOptimization(BailoutReason reason) {
info_->AbortOptimization(reason);
- return SetLastStatus(BAILED_OUT);
+ return SetLastStatus(FAILED);
}
void RecordOptimizationStats();
« no previous file with comments | « no previous file | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698