components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java - Issue 1926683003: [Cronet] Avoid crashing when CronetEngines are created on multiple threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

Issue 1926683003: [Cronet] Avoid crashing when CronetEngines are created on multiple threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address mef comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

index 9fd0059786cb37800cf349f82f0d2df360d20fc5..1c4140cbcdbc4e266121b385596e21bd8f7c73c1 100644

--- a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

@@ -76,7 +76,7 @@ class CronetUrlRequestContext extends CronetEngine {

new ObserverList<RequestFinishedListener>();

@UsedByReflection("CronetEngine.java")

- public CronetUrlRequestContext(CronetEngine.Builder builder) {

+ public CronetUrlRequestContext(final CronetEngine.Builder builder) {

CronetLibraryLoader.ensureInitialized(builder.getContext(), builder);

nativeSetMinLogLevel(getLoggingLevel());

synchronized (mLock) {

@@ -91,6 +91,7 @@ class CronetUrlRequestContext extends CronetEngine {

Runnable task = new Runnable() {

@Override

public void run() {

+ CronetLibraryLoader.ensureInitializedOnMainThread(builder.getContext());

synchronized (mLock) {

// mUrlRequestContextAdapter is guaranteed to exist until

// initialization on main and network threads completes and