Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1926673002:
👀 Make sure Android GN instrumentation test targets expose a _run alias (Closed)
DescriptionMake sure Android GN instrumentation test targets expose a _run alias
Required by recipes for GYP compatibility.
BUG=589318
Committed: https://crrev.com/7819534cfb29bb8d80c61668cde8341ffaca3ab3
Cr-Commit-Position: refs/heads/master@{#390082}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (7 generated)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926673002/1
Description was changed from ========== Make sure Android GN instrumentation test targets expose a _run alias Required by recipes for GYP compatibility. BUG=589318 ========== to ========== Make sure Android GN instrumentation test targets expose a _run alias Required by recipes for GYP compatibility. BUG=589318 ==========
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org
On 2016/04/27 13:31:14, commit-bot: I haz the power wrote: > Dry run: CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1926673002/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1926673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1926673002/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1926673002/diff/1/build/config/android/rules.... build/config/android/rules.gni:2062: ":${invoker.target_name}", I'm assuming this gets the right target name (i.e., the one without _run) because of the 'invoker.'?
On 2016/04/27 15:13:46, jbudorick wrote: > https://codereview.chromium.org/1926673002/diff/1/build/config/android/rules.gni > File build/config/android/rules.gni (right): > > https://codereview.chromium.org/1926673002/diff/1/build/config/android/rules.... > build/config/android/rules.gni:2062: ":${invoker.target_name}", > I'm assuming this gets the right target name (i.e., the one without _run) > because of the 'invoker.'? (er, lgtm w/ question)
https://codereview.chromium.org/1926673002/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1926673002/diff/1/build/config/android/rules.... build/config/android/rules.gni:2062: ":${invoker.target_name}", On 2016/04/27 15:13:46, jbudorick wrote: > I'm assuming this gets the right target name (i.e., the one without _run) > because of the 'invoker.'? it does :)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926673002/1
Message was sent while issue was closed.
Description was changed from ========== Make sure Android GN instrumentation test targets expose a _run alias Required by recipes for GYP compatibility. BUG=589318 ========== to ========== Make sure Android GN instrumentation test targets expose a _run alias Required by recipes for GYP compatibility. BUG=589318 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Make sure Android GN instrumentation test targets expose a _run alias Required by recipes for GYP compatibility. BUG=589318 ========== to ========== Make sure Android GN instrumentation test targets expose a _run alias Required by recipes for GYP compatibility. BUG=589318 Committed: https://crrev.com/7819534cfb29bb8d80c61668cde8341ffaca3ab3 Cr-Commit-Position: refs/heads/master@{#390082} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7819534cfb29bb8d80c61668cde8341ffaca3ab3 Cr-Commit-Position: refs/heads/master@{#390082} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
