Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/standalone.gypi

Issue 1926633004: Use third_party clang on Mac. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tie it to clang_xcode. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index b26f54bb6403d0a92a115ce3424bf1874da0aa5a..84d5e2ddfdb74d4f693ba4449735e527ebc43071 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -1039,6 +1039,13 @@
'CLANG_CXX_LANGUAGE_STANDARD': 'c++11', # -std=c++11
},
'conditions': [
+ ['clang_xcode==0', {
+ 'xcode_settings': {
+ 'CC': '<(clang_dir)/bin/clang',
+ 'LDPLUSPLUS': '<(clang_dir)/bin/clang++',
+ 'CLANG_CXX_LIBRARY': 'libc++'
+ },
+ }],
['v8_target_arch=="x64" or v8_target_arch=="arm64" \
or v8_target_arch=="mips64el"', {
'xcode_settings': {'WARNING_CFLAGS': ['-Wshorten-64-to-32']},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698