bluetooth: Remove the device info and device class fields from BluetoothDevice.

bluetooth: Remove the device info and device class fields from BluetoothDevice.

BUG=607104
Committed: https://crrev.com/10e8933627cf2753881d6106ec9f480454f0d72d
Cr-Commit-Position: refs/heads/master@{#391180}

[François Beaufort, 2016-04-27 09:35:28]

The CQ bit was checked by beaufort.francois@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 09:35:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926623002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926623002/40001

[commit-bot: I haz the power, 2016-04-27 09:35:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 09:35:41]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[fbeaufortchromium, 2016-04-27 09:36:56]

The CQ bit was checked by fbeaufort@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 09:37:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926623002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926623002/40001

[François Beaufort, 2016-04-27 11:23:50]

beaufort.francois@gmail.com changed reviewers:
+ scheib@chromium.org
- fbeaufort@chromium.org

[François Beaufort, 2016-04-27 11:23:51]

Hello Vincent,

Can you have a quick look at this CL?

[commit-bot: I haz the power, 2016-04-27 11:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 11:39:31]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-04-27 14:38:38]

ortuno@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2016-04-27 14:38:38]

I wonder if we should mark these as deprecated first. The same way we did
connectGATT and instanceID.

[François Beaufort, 2016-04-27 14:40:32]

On 2016/04/27 14:38:38, ortuno wrote:
> I wonder if we should mark these as deprecated first. The same way we did
> connectGATT and instanceID.

FWIW, I didn't see anyone using these with Web Bluetooth since I've started
monitoring their usage.

[scheib, 2016-04-27 18:13:09]

so far, looking good, but I think go all the way to removing the fields from 
content/common/bluetooth/bluetooth_device.h.
content/browser/bluetooth/bluetooth_dispatcher_host.cc

[scheib, 2016-04-27 18:14:49]

On 2016/04/27 14:38:38, ortuno wrote:
> I wonder if we should mark these as deprecated first. The same way we did
> connectGATT and instanceID.

I think we should just get this done. We're still experimental and don't expect
this to break most apps. Even ones using the fields will most likely just get
'undefined' values but not crash.

[François Beaufort, 2016-04-27 19:31:17]

On 2016/04/27 18:14:49, scheib wrote:
> On 2016/04/27 14:38:38, ortuno wrote:
> > I wonder if we should mark these as deprecated first. The same way we did
> > connectGATT and instanceID.
> 
> I think we should just get this done. We're still experimental and don't
expect
> this to break most apps. Even ones using the fields will most likely just get
> 'undefined' values but not crash.

Here's a new patchset that removes all fields in content/

[scheib, 2016-04-27 19:47:20]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 19:47:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926623002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926623002/60001

[commit-bot: I haz the power, 2016-04-27 20:02:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 20:02:49]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[François Beaufort, 2016-04-27 20:09:15]

On 2016/04/27 20:02:49, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
>   linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Just uploaded a new patchset to fix mock issue.

[ortuno, 2016-04-27 20:16:41]

https://codereview.chromium.org/1926623002/diff/80001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(left):

https://codereview.chromium.org/1926623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:591:
adapter, 0x1F00 /* Bluetooth class */, device_name, address,
You still need these. Bluez still relies on this constructor for its tests.

https://codereview.chromium.org/1926623002/diff/80001/device/bluetooth/test/m...
File device/bluetooth/test/mock_bluetooth_device.h (left):

https://codereview.chromium.org/1926623002/diff/80001/device/bluetooth/test/m...
device/bluetooth/test/mock_bluetooth_device.h:28: uint32_t bluetooth_class,
I don't think you should remove these from these mocks. I'm sure Bluez tests
need the values from these mocks.

[fbeaufortchromium, 2016-04-28 06:48:23]

The CQ bit was checked by fbeaufort@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 06:48:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926623002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926623002/100001

[commit-bot: I haz the power, 2016-04-28 10:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 10:16:54]

Dry run: This issue passed the CQ dry run.

[François Beaufort, 2016-04-28 10:19:02]

On 2016/04/28 10:16:54, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Thanks Gio!
I've updated patchset and reverted BlueZ Mocks changes.

Let me know how it looks like now.

[ortuno, 2016-04-28 15:52:19]

lgtm bar one small thing. You want to add palmer for security review of
bluetooth_messages.h

https://codereview.chromium.org/1926623002/diff/100001/content/shell/browser/...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(left):

https://codereview.chromium.org/1926623002/diff/100001/content/shell/browser/...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:358:
//  - GetBluetoothClass:
Can you remove the lines that set this values (610-614) in the .cc file; I don't
thin anyone is using them now:

https://code.google.com/p/chromium/codesearch#chromium/src/content/shell/brow...

[ortuno, 2016-04-28 15:52:30]

Also thanks for doing this! :)

[François Beaufort, 2016-04-28 16:28:50]

beaufort.francois@gmail.com changed reviewers:
+ palmer@chromium.org

[François Beaufort, 2016-04-28 16:28:51]

Thank you Gio! I've removed lines you've mentioned.

@palmer Please, can you have a look at
	content/common/bluetooth/bluetooth_messages.h

[ortuno, 2016-04-28 16:30:38]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 16:30:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926623002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926623002/120001

[scheib, 2016-04-28 16:55:58]

LGTM

[commit-bot: I haz the power, 2016-04-28 17:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 17:48:04]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[François Beaufort, 2016-05-02 18:22:49]

On 2016/04/28 17:48:04, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

palmer (gentle ping)

Please, can you have a look at content/common/bluetooth/bluetooth_messages.h ?

[palmer, 2016-05-02 22:08:24]

lgtm

[ortuno, 2016-05-02 22:08:42]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 22:09:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926623002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926623002/120001

[commit-bot: I haz the power, 2016-05-03 01:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 01:39:58]

Dry run: This issue passed the CQ dry run.

[François Beaufort, 2016-05-03 06:27:24]

The CQ bit was checked by beaufort.francois@gmail.com

[François Beaufort, 2016-05-03 06:27:25]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/1926623002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-05-03 06:27:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926623002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926623002/120001

[commit-bot: I haz the power, 2016-05-03 06:32:02]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-05-03 06:33:15]

Description was changed from

==========
bluetooth: Remove the device info and device class fields from BluetoothDevice.

BUG=607104
==========

to

==========
bluetooth: Remove the device info and device class fields from BluetoothDevice.

BUG=607104

Committed: https://crrev.com/10e8933627cf2753881d6106ec9f480454f0d72d
Cr-Commit-Position: refs/heads/master@{#391180}
==========

[commit-bot: I haz the power, 2016-05-03 06:33:17]

Patchset 7 (id:??) landed as
https://crrev.com/10e8933627cf2753881d6106ec9f480454f0d72d
Cr-Commit-Position: refs/heads/master@{#391180}