Web Animations: Introduce ActiveAnimations and AnimationStack

Source/core/animation/AnimationStack.h

+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef AnimationStack_h
+#define AnimationStack_h
+
+#include "wtf/HashMap.h"
+#include "wtf/RefPtr.h"
+#include "wtf/Vector.h"
+
+namespace WebCore {
+
+class Element;
+class Animation;
+
+class AnimationStack {
+

[esprehn, 2013/07/17 06:48:01]

Extra nl

[dstockwell, 2013/07/17 13:10:19]

Done.

+public:
+    AnimationStack() { };

[esprehn, 2013/07/17 06:48:01]

Leave off default constructor

[dstockwell, 2013/07/17 13:10:19]

Done.

+    void add(const Element*, Animation*);
+    void remove(const Element*, Animation*);
+    bool hasActiveAnimations(const Element* element) const { return m_elementAnimations.contains(element); }
+    void remove(const Element* element) { m_elementAnimations.remove(element); }

[esprehn, 2013/07/17 06:48:01]

removeAll ? Also why is this one inline but ::add isn't?

[dstockwell, 2013/07/17 13:10:19]

Done.
Only because ::add is marginally non-trivial, and will likely become more
complicated.

+    // FIXME: This should be PassRefPtr<CompositableValue> composite(Element*, CSSPropertyId)
+    const Vector<Animation*>& activeAnimations(const Element* element) { return m_elementAnimations.find(element)->value; }
+
+private:
+    typedef HashMap<const Element*, Vector<Animation*> > ElementAnimationMap;
+    ElementAnimationMap m_elementAnimations;
+};
+
+} // namespace WebCore
+
+#endif