Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 1926573002: [Findit] Adding test to improve code coverage (Closed)

Created:
4 years, 7 months ago by lijeffrey
Modified:
4 years, 7 months ago
Reviewers:
chanli, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Adding test to improve code coverage BUG=604096 Committed: https://chromium.googlesource.com/infra/infra/+/6b287728967ff7839d3442240e5b24219e600095

Patch Set 1 #

Patch Set 2 : Fixing unintended change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
lijeffrey
It seems Findit still report 100.0% code coverage despite line 458 missing the implied else ...
4 years, 7 months ago (2016-04-27 05:48:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926573002/1
4 years, 7 months ago (2016-04-27 05:48:22 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-04-27 05:48:23 UTC) #6
lijeffrey
Nevermind, I guess I don't have permission to do that, ptal as soon as you ...
4 years, 7 months ago (2016-04-27 05:49:15 UTC) #7
stgao
lgtm
4 years, 7 months ago (2016-04-27 17:09:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926573002/20001
4 years, 7 months ago (2016-04-27 17:09:52 UTC) #10
stgao
On 2016/04/27 05:49:15, lijeffrey wrote: > Nevermind, I guess I don't have permission to do ...
4 years, 7 months ago (2016-04-27 17:10:58 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 17:14:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/6b287728967ff7839d3442240e5b2...

Powered by Google App Engine
This is Rietveld 408576698