Issue 1926563002: [ios] Do not allow loading chrome:// URLs from regular http/https pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1926563002: [ios] Do not allow loading chrome:// URLs from regular http/https pages. (Closed)

Created:
4 years, 7 months ago by Eugene But (OOO till 7-30)

Modified:
4 years, 7 months ago

Reviewers:
Andy Caruso

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

More Reviews

Description

[ios] Do not allow loading chrome:// URLs from regular http/https pages. Merged trunk CL: https://codereview.chromium.org/1900783003/ BUG=604086 NOTRY=true NOPRESUBMIT=true TEST=WebUI still works, but can not be loaded from http/https pages

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	ios/web/web_state/ui/crw_wk_web_view_web_controller.mm	View		1 chunk	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Andy Caruso

On 2016/04/29 22:16:19, Eugene But wrote: > Andy? lgtm

4 years, 7 months ago (2016-04-29 22:18:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926563002/1

4 years, 7 months ago (2016-04-29 22:24:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages