components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc - Issue 1926553002: Prompt for expiration date for local cards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

Issue 1926553002: Prompt for expiration date for local cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify the test cases Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/personal_data_manager.h ('k') | components/autofill/core/browser/ui/card_unmask_prompt_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

diff --git a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc b/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

index d7a1dab411d73352a8d96938098e783a9c369a02..bca4af7762df8460542a41d01f48f1bf822ef79f 100644

--- a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

+++ b/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

@@ -10,6 +10,7 @@

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/time/time.h"

#include "build/build_config.h"

#include "components/autofill/core/browser/autofill_experiments.h"

#include "components/autofill/core/browser/autofill_metrics.h"

@@ -267,7 +268,7 @@ int CardUnmaskPromptControllerImpl::GetCvcImageRid() const {

}

bool CardUnmaskPromptControllerImpl::ShouldRequestExpirationDate() const {

- return card_.GetServerStatus() == CreditCard::EXPIRED ||

+ return card_.ShouldUpdateExpiration(base::Time::Now()) ||

new_card_link_clicked_;

}