Prompt for expiration date for local cards.

components/autofill/core/browser/credit_card.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/credit_card.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 768 matching lines @@
   }
 
   return false;
 }
 
 bool CreditCard::IsExpired(const base::Time& current_time) const {
   return !IsValidCreditCardExpirationDate(expiration_year_, expiration_month_,
                                           current_time);
 }
 
+bool CreditCard::ShouldUpdateExpiration(const base::Time& current_time) const {
+  switch (record_type()) {
+    case LOCAL_CARD:
+      return IsExpired(current_time);
+    case MASKED_SERVER_CARD:
+    case FULL_SERVER_CARD:
+      return server_status_ == EXPIRED || IsExpired(current_time);

[Mathieu, 2016/04/27 19:54:50]

looks like this function could be replaced with

return server_status_ == EXPIRED || IsExpired(current_time);

because a local card will have server_status_ == OK. What do you think?

[please use gerrit instead, 2016/04/28 00:30:24]

Done.

+  }
+  NOTREACHED();
+  return false;
+}
+
 // So we can compare CreditCards with EXPECT_EQ().
 std::ostream& operator<<(std::ostream& os, const CreditCard& credit_card) {
   return os << base::UTF16ToUTF8(credit_card.Label()) << " "
             << credit_card.guid() << " " << credit_card.origin() << " "
             << base::UTF16ToUTF8(credit_card.GetRawInfo(CREDIT_CARD_NAME_FULL))
             << " "
             << base::UTF16ToUTF8(credit_card.GetRawInfo(CREDIT_CARD_TYPE))
             << " "
             << base::UTF16ToUTF8(credit_card.GetRawInfo(CREDIT_CARD_NUMBER))
             << " "
             << base::UTF16ToUTF8(credit_card.GetRawInfo(CREDIT_CARD_EXP_MONTH))
             << " " << base::UTF16ToUTF8(
                           credit_card.GetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR));
 }
 
 // These values must match the values in WebKitPlatformSupportImpl in
 // webkit/glue. We send these strings to WebKit, which then asks
 // WebKitPlatformSupportImpl to load the image data.
 const char kAmericanExpressCard[] = "americanExpressCC";
 const char kDinersCard[] = "dinersCC";
 const char kDiscoverCard[] = "discoverCC";
 const char kGenericCard[] = "genericCC";
 const char kJCBCard[] = "jcbCC";
 const char kMasterCard[] = "masterCardCC";
 const char kUnionPay[] = "unionPayCC";
 const char kVisaCard[] = "visaCC";
 
 }  // namespace autofill