Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1926523002: Rename gfx::Display/Screen to display::Display/Screen in components (Closed)

Created:
4 years, 8 months ago by oshima
Modified:
4 years, 7 months ago
CC:
asvitkine+watch_chromium.org, blundell+watchlist_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, droger+watchlist_chromium.org, estade+watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, rjkroege, rouslan+autofill_chromium.org, sdefresne+watchlist_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in components BUG=597761 Committed: https://crrev.com/ecaa7b69fd0c7c700d0808548e4b3248c9233955 Cr-Commit-Position: refs/heads/master@{#390455}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -32 lines) Patch
M components/autofill.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/content/browser/risk/fingerprint.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/dom_distiller.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/content/browser/distiller_page_web_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/exo.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 5 chunks +19 lines, -19 lines 0 comments Download
M components/metrics.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/ui/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/ui/screen_info_metrics_provider.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/ws/platform_display.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 34 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926523002/1
4 years, 8 months ago (2016-04-27 01:54:28 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/57346) android_chromium_gn_compile_rel on ...
4 years, 8 months ago (2016-04-27 01:58:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926523002/20001
4 years, 7 months ago (2016-04-27 17:40:12 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926523002/60001
4 years, 7 months ago (2016-04-27 17:47:38 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/57325) linux_android_rel_ng on ...
4 years, 7 months ago (2016-04-27 17:53:43 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926523002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926523002/80001
4 years, 7 months ago (2016-04-27 18:12:45 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 19:16:00 UTC) #15
oshima
isherman@ -> autofill/metrics mdjones@ -> dom_distiller reveman@ -> exo msw@ -> mus
4 years, 7 months ago (2016-04-27 20:19:10 UTC) #22
Ilya Sherman
LGTM, thanks!
4 years, 7 months ago (2016-04-27 20:51:52 UTC) #24
reveman
lgtm
4 years, 7 months ago (2016-04-27 22:03:34 UTC) #25
mdjones
lgtm
4 years, 7 months ago (2016-04-28 00:37:31 UTC) #26
oshima
msw@: ping?
4 years, 7 months ago (2016-04-28 17:51:33 UTC) #27
msw
Sorry I somehow missed this... components/mus lgtm
4 years, 7 months ago (2016-04-28 18:24:20 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926523002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926523002/80001
4 years, 7 months ago (2016-04-28 18:25:26 UTC) #30
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 7 months ago (2016-04-28 20:04:51 UTC) #32
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:20:29 UTC) #33
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ecaa7b69fd0c7c700d0808548e4b3248c9233955
Cr-Commit-Position: refs/heads/master@{#390455}

Powered by Google App Engine
This is Rietveld 408576698