Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 19265002: Make TransitionArray internal references originate from TA in heap snapshot. (Closed)

Created:
7 years, 5 months ago by alph
Modified:
7 years, 5 months ago
Reviewers:
yurys, Toon Verwaest, loislo
CC:
v8-dev
Visibility:
Public.

Description

Make TransitionArray internal references originate from TA in heap snapshot. TransitionArray references were added to the TA's map object instead of TA itself. R=verwaest@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15692

Patch Set 1 #

Patch Set 2 : Update the test. #

Patch Set 3 : Moved TransitionArray processing into Map. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M src/heap-snapshot-generator.cc View 1 2 11 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alph
Yury, Toon, could you please take a look.
7 years, 5 months ago (2013-07-15 18:39:15 UTC) #1
Toon Verwaest
I definitely support the content of this change; but be aware that IsTransitionArray just implies ...
7 years, 5 months ago (2013-07-15 21:15:10 UTC) #2
alph
On 2013/07/15 21:15:10, Toon Verwaest wrote: > I definitely support the content of this change; ...
7 years, 5 months ago (2013-07-16 11:31:32 UTC) #3
Toon Verwaest
Cool, lgtm.
7 years, 5 months ago (2013-07-16 11:44:02 UTC) #4
yurys
lgtm
7 years, 5 months ago (2013-07-16 12:16:02 UTC) #5
alph
7 years, 5 months ago (2013-07-16 12:48:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r15692 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698