Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1926493003: Remove now-dead DefineDataPropertyUnchecked (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove now-dead DefineDataPropertyUnchecked BUG= Committed: https://crrev.com/41acd51bc3d89e0af6209af5736a60b3c0316474 Cr-Commit-Position: refs/heads/master@{#35823}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -81 lines) Patch
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M test/mjsunit/es6/reflect-define-property.js View 1 3 chunks +1 line, -26 lines 0 comments Download
M test/mjsunit/object-define-property.js View 1 3 chunks +1 line, -26 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 7 months ago (2016-04-27 09:46:31 UTC) #2
Jakob Kummerow
lgtm
4 years, 7 months ago (2016-04-27 12:46:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926493003/20001
4 years, 7 months ago (2016-04-27 12:57:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 13:21:12 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 13:22:25 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/41acd51bc3d89e0af6209af5736a60b3c0316474
Cr-Commit-Position: refs/heads/master@{#35823}

Powered by Google App Engine
This is Rietveld 408576698