[Findit] Adding new fields to try job metadata and updating as soon as possible

appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 import json
 import time
 
+from common.waterfall import buildbucket_client
 from common.waterfall import try_job_error
-from common.waterfall import buildbucket_client
 from model import analysis_status
 from model.wf_try_job import WfTryJob
 from model.wf_try_job_data import WfTryJobData
 from waterfall import waterfall_config
 from waterfall.monitor_try_job_pipeline import MonitorTryJobPipeline
 from waterfall.test import wf_testcase
 from waterfall.try_job_type import TryJobType
 
 
 # A counter to enable different responses to requests in a loop.
@@ skipping 116 matching lines @@
         'reason': 'BUILD_NOT_FOUND',
         'message': 'message'
     }
     error = buildbucket_client.BuildbucketError(error_data)
     try_job_data = WfTryJobData.Create('1')
 
     MonitorTryJobPipeline._UpdateTryJobMetadata(
         try_job_data, None, None, error, False)
     self.assertEqual(try_job_data.error, error_data)
 
-  def testUpdateTryJobMetadataForCompletedBuild(self):
+  def testUpdateTryJobMetadata(self):
     try_job_id = '1'
     url = 'url'
     build_data = {
         'id': try_job_id,
         'url': url,
         'status': 'COMPLETED',
         'completed_ts': '1454367574000000',
         'created_ts': '1454367570000000',
         'result_details_json': json.dumps({
             'properties': {
                 'report': {
                     'result': {
                         'rev1': 'passed',
                         'rev2': 'failed'
                     },
                     'metadata': {
                         'regression_range_size': 2
                     }
                 }
             }
         })
     }
     build = buildbucket_client.BuildbucketBuild(build_data)
-    try_job_data = WfTryJobData.Create(try_job_id)
-
     expected_error_dict = {
         'message': 'Try job monitoring was abandoned.',
         'reason': ('Timeout after %s hours' %
                    waterfall_config.GetTryJobSettings().get(
                        'job_timeout_hours'))
     }
+    try_job_data = WfTryJobData.Create(try_job_id)
 
     MonitorTryJobPipeline._UpdateTryJobMetadata(
         try_job_data, None, build, None, False)
     try_job_data = WfTryJobData.Get(try_job_id)
     self.assertIsNone(try_job_data.error)
     self.assertEqual(try_job_data.regression_range_size, 2)
     self.assertEqual(try_job_data.number_of_commits_analyzed, 2)
     self.assertEqual(try_job_data.end_time, datetime(2016, 2, 1, 22, 59, 34))
     self.assertEqual(try_job_data.request_time,
                      datetime(2016, 2, 1, 22, 59, 30))
@@ skipping 57 matching lines @@
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
     try_job_id = '3'
 
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.test_results = [
         {
             'report': None,
             'url': 'url',
-            'try_job_id': '3',
+            'try_job_id': try_job_id,
         }
     ]
     try_job.status = analysis_status.RUNNING
     try_job.put()
+
+    try_job_data = WfTryJobData.Create(try_job_id)
+    try_job_data.put()
+
     self._MockGetTryJobs(try_job_id)
 
     pipeline = MonitorTryJobPipeline()
     test_result = pipeline.run(
         master_name, builder_name, build_number, TryJobType.TEST,
         try_job_id)
 
     expected_test_result = {
         'report': {
             'result': {
@@ skipping 141 matching lines @@
     }
 
     expected_error_dict = {
         'message': 'No result report was found.',
         'reason': MonitorTryJobPipeline.UNKNOWN
     }
 
     self.assertEqual(
         MonitorTryJobPipeline._GetError(build_response, None, False),
         (expected_error_dict, try_job_error.UNKNOWN))