[Findit] Adding new fields to try job metadata and updating as soon as possible

appengine/findit/waterfall/schedule_try_job_pipeline.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from common.pipeline_wrapper import BasePipeline
 from common.pipeline_wrapper import pipeline
 from common.waterfall import buildbucket_client
 from model.wf_try_job import WfTryJob
+from model.wf_try_job_data import WfTryJobData
 from waterfall import buildbot
 from waterfall import waterfall_config
 from waterfall.try_job_type import TryJobType
 
 
 class ScheduleTryJobPipeline(BasePipeline):
   """A pipeline for scheduling a new try job for current build."""
 
   def _GetBuildProperties(
       self, master_name, builder_name, build_number, good_revision,
@@ skipping 36 matching lines @@
 
     try_job = buildbucket_client.TryJob(
         tryserver_mastername, tryserver_buildername, None, properties, [])
     error, build = buildbucket_client.TriggerTryJobs([try_job])[0]
 
     if error:  # pragma: no cover
       raise pipeline.Retry(
           'Error "%s" occurred. Reason: "%s"' % (error.message, error.reason))
 
     try_job_result = WfTryJob.Get(master_name, builder_name, build_number)
+    build_id = build.id
+
     if try_job_type == TryJobType.COMPILE:
-      try_job_result.compile_results.append({'try_job_id': build.id})
+      try_job_result.compile_results.append({'try_job_id': build_id})
     else:
-      try_job_result.test_results.append({'try_job_id': build.id})
-    try_job_result.try_job_ids.append(build.id)
+      try_job_result.test_results.append({'try_job_id': build_id})
+    try_job_result.try_job_ids.append(build_id)
     try_job_result.put()
 
-    return build.id
+    # Create a corresponding WfTryJobData entity to capture as much metadata as
+    # early as possible.
+    assert build_id

[stgao, 2016/04/27 17:34:33]

No need to assert here. If no error, build id will always be set by buildbucket.

[lijeffrey, 2016/04/27 22:21:03]

Done.

+    try_job_data = WfTryJobData.Create(build_id)
+    try_job_data.master_name = master_name
+    try_job_data.builder_name = builder_name
+    try_job_data.build_number = build_number
+    try_job_data.try_job_type = try_job_type
+    try_job_data.has_compile_targets = bool(compile_targets)
+    try_job_data.has_heuristic_results = bool(suspected_revisions)
+    try_job_data.put()
+
+    return build_id