appengine/swarming/server/task_scheduler_test.py - Issue 1926443003: swarming: read configs from luci-config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/swarming/server/task_scheduler_test.py

Issue 1926443003: swarming: read configs from luci-config (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master

Patch Set: do not specify target in cron.yaml Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/swarming/server/config.py ('K') | « appengine/swarming/server/config.py ('k') | appengine/swarming/templates/restricted_config.html » ('j') | appengine/swarming/templates/restricted_config.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/swarming/server/task_scheduler_test.py

diff --git a/appengine/swarming/server/task_scheduler_test.py b/appengine/swarming/server/task_scheduler_test.py

index 429a221a4d0df460d78c55dca8bb88528a54022c..b975205553b575f57d91d1de89bb79e52d74479b 100755

--- a/appengine/swarming/server/task_scheduler_test.py

+++ b/appengine/swarming/server/task_scheduler_test.py

@@ -402,7 +402,7 @@ class TaskSchedulerApiTest(test_case.TestCase):

self.mock(random, 'getrandbits', lambda _: 0x88)

cfg = config.settings()

cfg.reusable_task_age_secs = 10

- cfg.store()

+ self.mock(config, 'settings', lambda: cfg)

# First task is idempotent.

self._task_ran_successfully()

@@ -413,9 +413,7 @@ class TaskSchedulerApiTest(test_case.TestCase):

# Now any of the 2 tasks could be reused. Assert the right one (the most

# recent) is reused.

- cfg = config.settings()

cfg.reusable_task_age_secs = 100

- cfg.store()

# Third task is deduped against second task. That ensures ordering works

# correctly.