Turn on assert_no_deps for blink in browser

Turn on assert_no_deps for blink in browser

R=brettw@chromium.org
BUG=582206
Committed: https://crrev.com/ffb95be04fb4effb750884083cb1c166c5499b7a
Cr-Commit-Position: refs/heads/master@{#390123}

[scottmg, 2016-04-26 22:05:07]

Bizarrely this passes gn gen --check and links in both debug and release, but
the dependency is still there
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/de....
Don't quite understand.

[scottmg, 2016-04-26 22:29:24]

FWIW:

[no-blink-in-browser]d:\src\cr3\src>..\dbg

[no-blink-in-browser]d:\src\cr3\src>gn gen //out/Debug "--args=is_debug=true
is_component_build=true enable_nacl=false is_chrome_branded=true symbol_level=2
is_win_fastlink=true target_cpu=\"x86\" win_console_app=true" --check
Done. Wrote 3702 targets from 854 files in 1688ms

[no-blink-in-browser]d:\src\cr3\src>..\rel

[no-blink-in-browser]d:\src\cr3\src>gn gen //out/Release "--args=is_debug=false
is_chrome_branded=true is_component_build=false symbol_level=2
dcheck_always_on=true is_win_fastlink=true target_cpu=\"x86\"" --check
Done. Wrote 5497 targets from 898 files in 2492ms

[no-blink-in-browser]d:\src\cr3\src>ninja -C out\Debug chrome
ninja: Entering directory `out\Debug'
[0->1853/1853 ~0] STAMP obj/chrome/chrome.stamp

[no-blink-in-browser]d:\src\cr3\src>ninja -C out\Release chrome
ninja: Entering directory `out\Release'
[0->2401/2401 ~0] STAMP obj/chrome/chrome.stamp

[no-blink-in-browser]d:\src\cr3\src>

[scottmg, 2016-04-26 22:55:42]

On 2016/04/26 22:29:24, scottmg wrote:
> FWIW:
> 
> [no-blink-in-browser]d:\src\cr3\src>..\dbg
> 
> [no-blink-in-browser]d:\src\cr3\src>gn gen //out/Debug "--args=is_debug=true
> is_component_build=true enable_nacl=false is_chrome_branded=true
symbol_level=2
> is_win_fastlink=true target_cpu=\"x86\" win_console_app=true" --check
> Done. Wrote 3702 targets from 854 files in 1688ms
> 
> [no-blink-in-browser]d:\src\cr3\src>..\rel
> 
> [no-blink-in-browser]d:\src\cr3\src>gn gen //out/Release
"--args=is_debug=false
> is_chrome_branded=true is_component_build=false symbol_level=2
> dcheck_always_on=true is_win_fastlink=true target_cpu=\"x86\"" --check
> Done. Wrote 5497 targets from 898 files in 2492ms
> 
> [no-blink-in-browser]d:\src\cr3\src>ninja -C out\Debug chrome
> ninja: Entering directory `out\Debug'
> [0->1853/1853 ~0] STAMP obj/chrome/chrome.stamp
> 
> [no-blink-in-browser]d:\src\cr3\src>ninja -C out\Release chrome
> ninja: Entering directory `out\Release'
> [0->2401/2401 ~0] STAMP obj/chrome/chrome.stamp
> 
> [no-blink-in-browser]d:\src\cr3\src>

Ah yes. Of course. nacl_loader_unittests.exe breaks in x64 rel only. Because.

[brettw, 2016-04-27 05:22:58]

lgtm

[scottmg, 2016-04-27 17:14:53]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-04-27 17:14:54]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1926443002/#ps20001
(title: "nacl_loader_unittests")

[commit-bot: I haz the power, 2016-04-27 17:15:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926443002/20001

[commit-bot: I haz the power, 2016-04-27 18:03:38]

Committed patchset #2 (id:20001)

[halliwell, 2016-04-30 00:22:46]

On 2016/04/27 18:03:38, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001)

This causes link errors in static debug builds: crbug.com/608114

[commit-bot: I haz the power, 2016-04-30 17:11:10]

Patchset 2 (id:??) landed as
https://crrev.com/ffb95be04fb4effb750884083cb1c166c5499b7a
Cr-Commit-Position: refs/heads/master@{#390123}

[commit-bot: I haz the power, 2016-04-30 17:50:48]

Description was changed from

==========
Turn on assert_no_deps for blink in browser

R=brettw@chromium.org
BUG=582206
==========

to

==========
Turn on assert_no_deps for blink in browser

R=brettw@chromium.org
BUG=582206

Committed: https://crrev.com/ffb95be04fb4effb750884083cb1c166c5499b7a
Cr-Commit-Position: refs/heads/master@{#390123}
==========

[scottmg, 2016-05-03 17:30:46]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1947643002/ by scottmg@chromium.org.

The reason for reverting is: debug static linux is sadness.

BUG=608114 and others..